Switch core API value types to noun-style accessors

Add noun-style accessors (record-accessor pattern) to core API
interfaces for immutable value types, consistent with modern JDK
conventions and existing Maven 4 API types (XmlNode, PathType,
Lifecycle.Phase, etc.).

For each method, the noun-style accessor is now the primary abstract
method. The existing getX() method is kept as a default delegating
to it, annotated @deprecated(since = "4.1.0", forRemoval = true).

Interfaces migrated: Artifact, ArtifactCoordinates, Dependency,
DependencyCoordinates, DownloadedArtifact, Exclusion, Project,
VersionConstraint, VersionRange.

Fixes #13035

Author: gnodet

api/maven-api-core/src/main/java/org/apache/maven/api/Artifact.java

@@ -29,7 +29,7 @@
  *
  * <p>Each {@code Artifact} instance is basically an exact pointer to a file in a Maven repository.
  * {@code Artifact} instances are created when <dfn>resolving</dfn> {@link ArtifactCoordinates} instances.
- * Resolving is the process that selects a {@linkplain #getVersion() particular version}
+ * Resolving is the process that selects a {@linkplain #version() particular version}
  * and downloads the artifact in the local repository.  This operation returns a {@link DownloadedArtifact}.
  * </p>
  *
@@ -46,32 +46,61 @@ public interface Artifact {
      */
     @Nonnull
     default String key() {
-        String c = getClassifier();
-        return getGroupId()
-                + ':'
-                + getArtifactId()
-                + ':'
-                + getExtension()
-                + (c.isEmpty() ? "" : ":" + c)
-                + ':'
-                + getVersion();
+        String c = classifier();
+        return groupId() + ':' + artifactId() + ':' + extension() + (c.isEmpty() ? "" : ":" + c) + ':' + version();
     }
 
+    /**
+     * {@return the group identifier of the artifact}.
+     *
+     * @see ArtifactCoordinates#groupId()
+     */
+    @Nonnull
+    String groupId();
+
     /**
      * {@return the group identifier of the artifact}.
      *
      * @see ArtifactCoordinates#getGroupId()
+     * @deprecated Use {@link #groupId()} instead.
+     */
+    @Deprecated(since = "4.1.0", forRemoval = true)
+    @Nonnull
+    default String getGroupId() {
+        return groupId();
+    }
+
+    /**
+     * {@return the identifier of the artifact}.
+     *
+     * @see ArtifactCoordinates#artifactId()
      */
     @Nonnull
-    String getGroupId();
+    String artifactId();
 
     /**
      * {@return the identifier of the artifact}.
      *
      * @see ArtifactCoordinates#getArtifactId()
+     * @deprecated Use {@link #artifactId()} instead.
      */
+    @Deprecated(since = "4.1.0", forRemoval = true)
     @Nonnull
-    String getArtifactId();
+    default String getArtifactId() {
+        return artifactId();
+    }
+
+    /**
+     * {@return the version of the artifact}.
+     * Contrarily to {@link ArtifactCoordinates},
+     * each {@code Artifact} is associated to a specific version instead of a range of versions.
+     * If the {@linkplain #baseVersion() base version} contains a meta-version such as {@code SNAPSHOT},
+     * those keywords are replaced by, for example, the actual timestamp.
+     *
+     * @see ArtifactCoordinates#versionConstraint()
+     */
+    @Nonnull
+    Version version();
 
     /**
      * {@return the version of the artifact}.
@@ -81,37 +110,82 @@ default String key() {
      * those keywords are replaced by, for example, the actual timestamp.
      *
      * @see ArtifactCoordinates#getVersionConstraint()
+     * @deprecated Use {@link #version()} instead.
+     */
+    @Deprecated(since = "4.1.0", forRemoval = true)
+    @Nonnull
+    default Version getVersion() {
+        return version();
+    }
+
+    /**
+     * {@return the version or meta-version of the artifact}.
+     * A meta-version is a version suffixed with the {@code SNAPSHOT} keyword.
+     * Meta-versions are represented in a base version by their symbols (e.g., {@code SNAPSHOT}),
+     * while they are replaced by, for example, the actual timestamp in the {@linkplain #version() version}.
      */
     @Nonnull
-    Version getVersion();
+    Version baseVersion();
 
     /**
      * {@return the version or meta-version of the artifact}.
      * A meta-version is a version suffixed with the {@code SNAPSHOT} keyword.
      * Meta-versions are represented in a base version by their symbols (e.g., {@code SNAPSHOT}),
      * while they are replaced by, for example, the actual timestamp in the {@linkplain #getVersion() version}.
+     *
+     * @deprecated Use {@link #baseVersion()} instead.
      */
+    @Deprecated(since = "4.1.0", forRemoval = true)
     @Nonnull
-    Version getBaseVersion();
+    default Version getBaseVersion() {
+        return baseVersion();
+    }
+
+    /**
+     * Returns the classifier of the artifact.
+     *
+     * @return the classifier or an empty string if none, never {@code null}
+     * @see ArtifactCoordinates#classifier()
+     */
+    @Nonnull
+    String classifier();
 
     /**
      * Returns the classifier of the artifact.
      *
      * @return the classifier or an empty string if none, never {@code null}
      * @see ArtifactCoordinates#getClassifier()
+     * @deprecated Use {@link #classifier()} instead.
+     */
+    @Deprecated(since = "4.1.0", forRemoval = true)
+    @Nonnull
+    default String getClassifier() {
+        return classifier();
+    }
+
+    /**
+     * Returns the file extension of the artifact.
+     * The dot separator is <em>not</em> included in the returned string.
+     *
+     * @return the file extension or an empty string if none, never {@code null}
+     * @see ArtifactCoordinates#extension()
      */
     @Nonnull
-    String getClassifier();
+    String extension();
 
     /**
      * Returns the file extension of the artifact.
      * The dot separator is <em>not</em> included in the returned string.
      *
      * @return the file extension or an empty string if none, never {@code null}
      * @see ArtifactCoordinates#getExtension()
+     * @deprecated Use {@link #extension()} instead.
      */
+    @Deprecated(since = "4.1.0", forRemoval = true)
     @Nonnull
-    String getExtension();
+    default String getExtension() {
+        return extension();
+    }
 
     /**
      * Determines whether this artifact uses a snapshot version.

api/maven-api-core/src/main/java/org/apache/maven/api/ArtifactCoordinates.java

@@ -36,28 +36,74 @@ public interface ArtifactCoordinates {
      * {@return the group identifier of the artifact}.
      */
     @Nonnull
-    String getGroupId();
+    String groupId();
+
+    /**
+     * {@return the group identifier of the artifact}.
+     *
+     * @deprecated Use {@link #groupId()} instead.
+     */
+    @Deprecated(since = "4.1.0", forRemoval = true)
+    @Nonnull
+    default String getGroupId() {
+        return groupId();
+    }
+
+    /**
+     * {@return the identifier of the artifact}.
+     */
+    @Nonnull
+    String artifactId();
 
     /**
      * {@return the identifier of the artifact}.
+     *
+     * @deprecated Use {@link #artifactId()} instead.
      */
+    @Deprecated(since = "4.1.0", forRemoval = true)
     @Nonnull
-    String getArtifactId();
+    default String getArtifactId() {
+        return artifactId();
+    }
 
     /**
      * Returns the classifier of the artifact.
      *
      * @return the classifier or an empty string if none, never {@code null}
      */
     @Nonnull
-    String getClassifier();
+    String classifier();
+
+    /**
+     * Returns the classifier of the artifact.
+     *
+     * @return the classifier or an empty string if none, never {@code null}
+     * @deprecated Use {@link #classifier()} instead.
+     */
+    @Deprecated(since = "4.1.0", forRemoval = true)
+    @Nonnull
+    default String getClassifier() {
+        return classifier();
+    }
+
+    /**
+     * {@return the specific version, range of versions, or meta-version of the artifact}.
+     * A meta-version is a version suffixed with the {@code SNAPSHOT} keyword.
+     */
+    @Nonnull
+    VersionConstraint versionConstraint();
 
     /**
      * {@return the specific version, range of versions, or meta-version of the artifact}.
      * A meta-version is a version suffixed with the {@code SNAPSHOT} keyword.
+     *
+     * @deprecated Use {@link #versionConstraint()} instead.
      */
+    @Deprecated(since = "4.1.0", forRemoval = true)
     @Nonnull
-    VersionConstraint getVersionConstraint();
+    default VersionConstraint getVersionConstraint() {
+        return versionConstraint();
+    }
 
     /**
      * Returns the file extension of the artifact.
@@ -66,7 +112,20 @@ public interface ArtifactCoordinates {
      * @return the file extension or an empty string if none, never {@code null}
      */
     @Nonnull
-    String getExtension();
+    String extension();
+
+    /**
+     * Returns the file extension of the artifact.
+     * The dot separator is <em>not</em> included in the returned string.
+     *
+     * @return the file extension or an empty string if none, never {@code null}
+     * @deprecated Use {@link #extension()} instead.
+     */
+    @Deprecated(since = "4.1.0", forRemoval = true)
+    @Nonnull
+    default String getExtension() {
+        return extension();
+    }
 
     /**
      * {@return a unique string identifying this artifact}.
@@ -78,14 +137,14 @@ public interface ArtifactCoordinates {
      */
     @Nonnull
     default String getId() {
-        String c = getClassifier();
-        return getGroupId()
+        String c = classifier();
+        return groupId()
                 + ':'
-                + getArtifactId()
+                + artifactId()
                 + ':'
-                + getExtension()
+                + extension()
                 + (c.isEmpty() ? "" : ":" + c)
                 + ':'
-                + getVersionConstraint();
+                + versionConstraint();
     }
 }

api/maven-api-core/src/main/java/org/apache/maven/api/Dependency.java

@@ -35,33 +35,61 @@
 @Experimental
 @Immutable
 public interface Dependency extends Artifact {
+    /**
+     * {@return the type of the dependency}.
+     * A dependency can be a <abbr>JAR</abbr> file,
+     * a modular-<abbr>JAR</abbr> if it is intended to be placed on the module path,
+     * a <abbr>JAR</abbr> containing test classes, <i>etc.</i>
+     *
+     * @see DependencyCoordinates#type()
+     */
+    @Nonnull
+    Type type();
+
     /**
      * {@return the type of the dependency}.
      * A dependency can be a <abbr>JAR</abbr> file,
      * a modular-<abbr>JAR</abbr> if it is intended to be placed on the module path,
      * a <abbr>JAR</abbr> containing test classes, <i>etc.</i>
      *
      * @see DependencyCoordinates#getType()
+     * @deprecated Use {@link #type()} instead.
+     */
+    @Deprecated(since = "4.1.0", forRemoval = true)
+    @Nonnull
+    default Type getType() {
+        return type();
+    }
+
+    /**
+     * {@return the time at which the dependency will be used}.
+     * It may be, for example, at compile time only, at run time or at test time.
+     *
+     * @see DependencyCoordinates#scope()
      */
     @Nonnull
-    Type getType();
+    DependencyScope scope();
 
     /**
      * {@return the time at which the dependency will be used}.
      * It may be, for example, at compile time only, at run time or at test time.
      *
      * @see DependencyCoordinates#getScope()
+     * @deprecated Use {@link #scope()} instead.
      */
+    @Deprecated(since = "4.1.0", forRemoval = true)
     @Nonnull
-    DependencyScope getScope();
+    default DependencyScope getScope() {
+        return scope();
+    }
 
     /**
      * Returns whether the dependency is optional or mandatory.
      * Unlike {@link DependencyCoordinates}, the obligation of a {@code Dependency} is always present.
      * The value is computed during the dependencies collection phase.
      *
      * @return {@code true} if the dependency is optional, or {@code false} if mandatory
-     * @see DependencyCoordinates#getOptional()
+     * @see DependencyCoordinates#optional()
      */
     boolean isOptional();