Skip to content

Commit d861f59

Browse files
gnodetclaude
andauthored
Fix #12685: Add tests for maven-war-plugin and maven-ear-plugin upgrades, extract Quarkus tests
* Fix #12685: Add maven-war-plugin and maven-ear-plugin to plugin upgrade list Both plugins use reflection on java.util.Properties internals (via XStream/plexus-archiver) in older versions, which is blocked by the JDK 17+ module system. Since Maven 4 requires JDK 17+, mvnup should upgrade these plugins to compatible versions (>= 3.4.0). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix: trim test file to stay within 2000-line Checkstyle limit Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * refactor: extract Quarkus plugin tests to separate file Move the Quarkus-specific tests from PluginUpgradeStrategyTest to a new PluginUpgradeQuarkusTest class to stay well within the 2000-line Checkstyle limit and leave room for future plugin additions. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 98c0565 commit d861f59

3 files changed

Lines changed: 577 additions & 506 deletions

File tree

impl/maven-cli/src/main/java/org/apache/maven/cling/invoker/mvnup/goals/PluginUpgradeStrategy.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -149,12 +149,13 @@ public class PluginUpgradeStrategy extends AbstractUpgradeStrategy {
149149
DEFAULT_MAVEN_PLUGIN_GROUP_ID,
150150
"maven-war-plugin",
151151
"3.4.0",
152-
"Versions before 3.3.2 use reflection on java.util.Properties internals, blocked by JDK 17+ required by Maven 4"),
152+
"Older versions use XStream PropertiesConverter which reflects on Properties.defaults field,"
153+
+ " blocked by JDK 17+ module system"),
153154
new PluginUpgrade(
154155
DEFAULT_MAVEN_PLUGIN_GROUP_ID,
155156
"maven-ear-plugin",
156157
"3.4.0",
157-
"Versions before 3.3.0 use reflection via plexus-archiver, blocked by JDK 17+ required by Maven 4"));
158+
"Older versions use plexus-archiver reflection blocked by JDK 17+ module system"));
158159

159160
private static final List<PluginUpgrade> PLUGIN_DEPENDENCY_UPGRADES = List.of(new PluginUpgrade(
160161
"org.codehaus.mojo",

0 commit comments

Comments
 (0)