[MNG-8671] Resolver context usage should be enforced

[jira-importer]

Tamas Cservenak opened MNG-8671 and commented

This one is tricky, as it tackles Maven Core but also Maven Plugins, basically {}everything that is using Resolver API{}.

All the Resolver request objects (most) carries "context" string, that is unused in Resolver itself, but carries possible extra information to those listening in, like "in which context is this resolver request executing".

Maven4 also offers similar API, maybe we want to target this issue for Maven 4 only, as again, properly fixing this in Maven 3 is nearly impossible, would tackle all code touching resolver APIs.

---

No further details from MNG-8671

[jira-importer]

Guillaume Nodet commented

Yes, I don't think we want to break all Maven 3 plugins, so targeting the new API would definitely make sense.

I think this can easily be done by:

• making RequestTrace non nullable on Request
• making context non nullable on RequestTrace

[jira-importer]

Guillaume Nodet commented

Maybe a better idea would be to scope requests:

try (var context = session.newContext(new RequestTrace("my-context"))) {
   ... send requests...
}

or

Session localSession = session.withContext(new RequestTrace("my-context"));
...

Else, we need to convey an extra parameter everywhere.

The second may more in line with the existing api which already defines withLocalRepository and withRemoteRepositories methods.

[goutamadwant]

@gnodet Implemented ithis enhancement in #13009.. following the proposed Session.withContext(RequestTrace) direction.Please let me know if you have any comments or suggestions. Thanks!