The org.apache.maven.api.plugin.testing package was relocated to org.apache.maven.testing.plugin in 4.0.0-rc-6 (8857e0eb18, "Deprecate testing classes in org.apache.maven.api, add new ones in org.apache.maven.testing"). Deprecated classes remain under the old names, so plugins keep compiling — but MojoExtension only recognises the new annotation types, so a plugin that has not moved its imports silently stops working.
findInjectMojoAttrs returns null for the deprecated @InjectMojo, so the @Basedir pom is never read and the mojo is handed MojoExtension's built-in defaultModel instead of the test project. Nothing warns; the test simply runs against the wrong model.
In maven-jar-plugin this surfaced as:
JarMojoTest.jarTestEnvironment:48 expected: <foo> but was: <myGroupId>
foo is the groupId in the @Basedir test pom; myGroupId is MojoExtension's default. Bisected: passes on 4.0.0-rc-4 and 4.0.0-rc-5, fails on rc-6. Pointing the imports at org.apache.maven.testing.plugin fixes it (apache/maven-jar-plugin#573).
In maven-source-plugin the same cause made @Basedir and @MojoParameter be ignored, producing target/null-sources.jar while the tests still reported green.
There is a second, related break in the same relocation. The shim left behind for ProducedArtifactStub:
@Deprecated(since = "4.0.0-rc-6", forRemoval = true)
public class ProducedArtifactStub extends org.apache.maven.testing.plugin.stubs.ProducedArtifactStub {
public ProducedArtifactStub();
}is a bare no-arg subclass. Constructors are not inherited, so the five-argument constructor the old class had is gone, and code using it no longer compiles:
CompilerMojoTestCase.java:[436,21] constructor ProducedArtifactStub ... cannot be applied to given types
required: no arguments found: String,String,<nulltype>,String,String
That one at least fails loudly (apache/maven-compiler-plugin#1104).
Suggestions, in rough order of value:
- Make the deprecated annotations work, or fail loudly. If
MojoExtension accepted both annotation types the relocation would be transparent; if that is not wanted, detecting a deprecated @InjectMojo/@Basedir and failing with a message naming the new package would at least turn a silent wrong-model run into an actionable error.
- Give the
ProducedArtifactStub shim the same five-argument constructor, so the deprecated class is source-compatible for its remaining life.
- Mention both in the release notes: "deprecated but still compiles, and no longer functions" is a combination that costs downstream projects a debugging session each.
Found while moving the plugins to rc-6 (#12676).
The
org.apache.maven.api.plugin.testingpackage was relocated toorg.apache.maven.testing.pluginin 4.0.0-rc-6 (8857e0eb18, "Deprecate testing classes in org.apache.maven.api, add new ones in org.apache.maven.testing"). Deprecated classes remain under the old names, so plugins keep compiling — butMojoExtensiononly recognises the new annotation types, so a plugin that has not moved its imports silently stops working.findInjectMojoAttrsreturns null for the deprecated@InjectMojo, so the@Basedirpom is never read and the mojo is handedMojoExtension's built-indefaultModelinstead of the test project. Nothing warns; the test simply runs against the wrong model.In maven-jar-plugin this surfaced as:
foois the groupId in the@Basedirtest pom;myGroupIdisMojoExtension's default. Bisected: passes on 4.0.0-rc-4 and 4.0.0-rc-5, fails on rc-6. Pointing the imports atorg.apache.maven.testing.pluginfixes it (apache/maven-jar-plugin#573).In maven-source-plugin the same cause made
@Basedirand@MojoParameterbe ignored, producingtarget/null-sources.jarwhile the tests still reported green.There is a second, related break in the same relocation. The shim left behind for
ProducedArtifactStub:is a bare no-arg subclass. Constructors are not inherited, so the five-argument constructor the old class had is gone, and code using it no longer compiles:
That one at least fails loudly (apache/maven-compiler-plugin#1104).
Suggestions, in rough order of value:
MojoExtensionaccepted both annotation types the relocation would be transparent; if that is not wanted, detecting a deprecated@InjectMojo/@Basedirand failing with a message naming the new package would at least turn a silent wrong-model run into an actionable error.ProducedArtifactStubshim the same five-argument constructor, so the deprecated class is source-compatible for its remaining life.Found while moving the plugins to rc-6 (#12676).