Problem with Date Format in ScpShell PathEntry

[araneolus]

Version

2.15.0

Bug description

WinScp will have Problem, if the sshd Server with the scpShell is start with German Local
Than the Files and Directory will be list with German "Umlaute" like this.

drw-rw-rw- 1 test group 0 März 4 11:56 test1

I have test it in my own ScpShell Class with the following DateTimeFormater and it works well than.

drw-rw-rw- 1 test group 0 Mar 4 11:56 test1

...
protected static class PathEntry implements Comparable {
public static final DateTimeFormatter FULL_TIME_VALUE_FORMATTER = DateTimeFormatter.ofPattern("MMM ppd HH:mm:ss yyyy",Locale.ENGLISH);
public static final DateTimeFormatter TIME_ONLY_VALUE_FORMATTER = DateTimeFormatter.ofPattern("MMM ppd HH:mm",Locale.ENGLISH);
public static final DateTimeFormatter YEAR_VALUE_FORMATTER = DateTimeFormatter.ofPattern("MMM ppd yyyy",Locale.ENGLISH);
...

Actual behavior

drw-rw-rw- 1 test group 0 März 4 11:56 test1

Expected behavior

drw-rw-rw- 1 test group 0 Mar 4 11:56 test1

Relevant log output

Other information

No response

[tomaswolf]

This is the "longname" field in SFTP v3. The Draft RFC explicitly points out that the format for that field was unspecified, so there is no promise at all on anything.

What problems does WinSCP have with German Umlaute?

That said, it might make sense for our server-side code to always use a defined locale for this. No need to expose information about the OS locale the server is running on.

[araneolus]

Error when displaying the directory "c:\temp\test"
Unexpected line in consumption list ...

Look to the screenshots of WinScp. I have connect the server with the scp Protocol. With sftp, it works well.
The problem is probably with WinScp but the ScpShell has just been implemented for WinScp according to the documentation,

Screen1 I have set the "SHELL_NAME_ENCODING_CHARSET" to US-ASCII, Screen2 to UTF-8.

[tomaswolf]

I see now that apparently WinSCP needs a server-side shell, and ScpShell was implemented specially for this as per SSHD-1009.

The date handling is different than in sshd-sftp.

Extremely strange, though, that WinSCP running on Windows with German language settings has trouble with a German month name. But indeed WinSCP expects always English month names.

We'll change it.