Add clang-tidy to gihub-workflows #2044
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add clang-tidy configuration file to enforce code quality and style
Set up build environment with necessary dependencies including clang-tidy, jq, and newt Configure Apache Mynewt NimBLE project with CMake and generate compile_commands.json Clean compile_commands.json by removing unsupported '-mthumb-interwork' flag to avoid clang errors Download and run clang-tidy-diff.py to analyze only changed lines based on git diff from origin/master Fail the workflow if clang-tidy reports warnings or errors in the diff, ensuring code quality on PRs and pushes
sjanc
reviewed
Jun 6, 2025
| shell: bash | ||
| run: | | ||
| COMPILE_COMMANDS="compile_commands.json" | ||
| if command -v jq >/dev/null 2>&1; then |
Contributor
There was a problem hiding this comment.
this check shouldn't be needed, all required tools shall be installed in previous steps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a GitHub Actions workflow that runs clang-tidy checks on changed lines only. It sets up the build environment, cleans compile_commands.json to avoid known clang errors, and uses clang-tidy-diff.py to efficiently lint code changes, helping maintain code quality on PRs and pushes.