Skip to content

Commit f0981ae

Browse files
committed
WIP: [C++] Bump Protobuf to v33.5
1 parent 14985e5 commit f0981ae

File tree

2 files changed

+13
-9
lines changed

2 files changed

+13
-9
lines changed

cmake_modules/ThirdpartyToolchain.cmake

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ set(LZ4_VERSION "1.10.0")
2626
set(SNAPPY_VERSION "1.2.2")
2727
set(ZLIB_VERSION "1.3.1")
2828
set(GTEST_VERSION "1.17.0")
29-
set(PROTOBUF_VERSION "3.21.12")
29+
set(PROTOBUF_VERSION "33.5")
3030
set(ZSTD_VERSION "1.5.7")
3131
set(SPARSEHASH_VERSION "2.11.1")
3232

@@ -209,7 +209,6 @@ else ()
209209

210210
fetchcontent_declare(Protobuf
211211
URL "https://github.com/google/protobuf/archive/v${PROTOBUF_VERSION}.tar.gz"
212-
SOURCE_SUBDIR "cmake"
213212
FIND_PACKAGE_ARGS
214213
NAMES Protobuf
215214
CONFIG
@@ -245,7 +244,14 @@ else ()
245244

246245
if(INSTALL_VENDORED_LIBS)
247246
set_target_properties(libprotobuf PROPERTIES OUTPUT_NAME "orc_vendored_protobuf")
248-
install(TARGETS libprotobuf
247+
set(_PROTOBUF_INSTALL_TARGETS libprotobuf)
248+
if(TARGET utf8_range)
249+
list(APPEND _PROTOBUF_INSTALL_TARGETS utf8_range)
250+
endif()
251+
if(TARGET utf8_validity)
252+
list(APPEND _PROTOBUF_INSTALL_TARGETS utf8_validity)
253+
endif()
254+
install(TARGETS ${_PROTOBUF_INSTALL_TARGETS}
249255
EXPORT orc_targets
250256
RUNTIME DESTINATION "${CMAKE_INSTALL_BINDIR}"
251257
ARCHIVE DESTINATION "${CMAKE_INSTALL_LIBDIR}"

subprojects/protobuf.wrap

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,15 +16,13 @@
1616
# under the License.
1717

1818
[wrap-file]
19-
directory = protobuf-3.21.12
20-
source_url = https://github.com/protocolbuffers/protobuf/archive/refs/tags/v3.21.12.tar.gz
21-
source_filename = protobuf-3.21.12.tar.gz
22-
source_hash = 930c2c3b5ecc6c9c12615cf5ad93f1cd6e12d0aba862b572e076259970ac3a53
19+
directory = protobuf-33.5
20+
source_url = https://github.com/protocolbuffers/protobuf/archive/refs/tags/v33.5.tar.gz
21+
source_filename = protobuf-33.5.tar.gz
22+
source_hash = 440848dffa209beb8a04e41cc352762e44f8e91342b2a43aab6af9b30713c2f6
2323
patch_filename = protobuf_3.21.12-5_patch.zip
2424
patch_url = https://wrapdb.mesonbuild.com/v2/protobuf_3.21.12-5/get_patch
2525
patch_hash = 8ae4d39ca9748a6edf7e028e15f5c7499b1c6ce687454a5709711d47cfd4e293
26-
source_fallback_url = https://github.com/mesonbuild/wrapdb/releases/download/protobuf_3.21.12-5/protobuf-3.21.12.tar.gz
27-
wrapdb_version = 3.21.12-5
2826

2927
[provide]
3028
protobuf = protobuf_dep

0 commit comments

Comments
 (0)