HDDS-15178. Allow creating EncodingTypeObject for empty String (#10195)

Author: peterxcli

hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/commontypes/EncodingTypeObject.java

@@ -18,7 +18,6 @@
 package org.apache.hadoop.ozone.s3.commontypes;
 
 import jakarta.annotation.Nullable;
-import org.apache.commons.lang3.StringUtils;
 
 /**
  * A converter to encode string if needed.
@@ -41,12 +40,12 @@ public String getName() {
   }
 
   /**
-   * Create a EncodingTypeObject Object, if the parameter name is null.
+   * Create a EncodingTypeObject Object, if the parameter name is not null.
    * @return If name is null return null else return a EncodingTypeObject object
    */
   @Nullable public static EncodingTypeObject createNullable(
       @Nullable String name, @Nullable String encodingType) {
-    if (StringUtils.isEmpty(name)) {
+    if (name == null) {
       return null;
     }
     return new EncodingTypeObject(name, encodingType);

hadoop-ozone/s3gateway/src/test/java/org/apache/hadoop/ozone/s3/commontypes/TestObjectKeyNameAdapter.java

@@ -42,6 +42,11 @@ public void testEncodeResult() throws Exception {
         .marshal(EncodingTypeObject.createNullable("a b c/", null)));
     assertEquals("a+b+c/", getAdapter()
         .marshal(EncodingTypeObject.createNullable("a+b+c/", null)));
+
+    assertEquals("", getAdapter()
+        .marshal(EncodingTypeObject.createNullable("", null)));
+    assertEquals("", getAdapter()
+        .marshal(EncodingTypeObject.createNullable("", ENCODING_TYPE)));
   }
 
   private XmlAdapter<String, EncodingTypeObject> getAdapter() {

hadoop-ozone/s3gateway/src/test/java/org/apache/hadoop/ozone/s3/endpoint/TestBucketList.java

@@ -58,6 +58,9 @@ public void listRoot() throws OS3Exception, IOException {
     endpoint.queryParamsForTest().set(QueryParams.PREFIX, "");
     ListObjectResponse getBucketResponse = (ListObjectResponse) endpoint.get("b1").getEntity();
 
+    assertNotNull(getBucketResponse.getPrefix());
+    assertEquals("", getBucketResponse.getPrefix().getName());
+
     assertEquals(1, getBucketResponse.getCommonPrefixes().size());
     assertEquals("dir1/",
         getBucketResponse.getCommonPrefixes().get(0).getPrefix().getName());