fix: Made the equals method more safe for NPEs in case of unresolvable typeReferences.

chrisdutz · chrisdutz · commit 9e011eec3170 · 2025-08-27T22:49:59.000+02:00
diff --git a/code-generation/protocol-base-mspec/src/main/java/org/apache/plc4x/plugins/codegenerator/language/mspec/model/terms/DefaultVariableLiteral.java b/code-generation/protocol-base-mspec/src/main/java/org/apache/plc4x/plugins/codegenerator/language/mspec/model/terms/DefaultVariableLiteral.java
@@ -98,7 +98,7 @@ public boolean equals(Object o) {
         DefaultVariableLiteral that = (DefaultVariableLiteral) o;
         return Objects.equals(index, that.index)
             && name.equals(that.name)
-            && typeReference.equals(that.typeReference)
+            && (typeReference != null) ? typeReference.equals(that.typeReference) : that.typeReference == null
             && Objects.equals(args, that.args)
             && Objects.equals(child, that.child);
     }

Original file line number	Diff line number	Diff line change
`@@ -98,7 +98,7 @@ public boolean equals(Object o) {`
`98`	`98`	`DefaultVariableLiteral that = (DefaultVariableLiteral) o;`
`99`	`99`	`return Objects.equals(index, that.index)`
`100`	`100`	`&& name.equals(that.name)`
`101`		`- && typeReference.equals(that.typeReference)`
	`101`	`+ && (typeReference != null) ? typeReference.equals(that.typeReference) : that.typeReference == null`
`102`	`102`	`&& Objects.equals(args, that.args)`
`103`	`103`	`&& Objects.equals(child, that.child);`
`104`	`104`	`}`