Some feature flags not working when set via environment variables in ECS task

[davidweimapbox]

Describe the bug

Polaris feature flags work when defined in application.properties inside the Docker image, but do not take effect when provided as environment variables in an ECS task definition.

The following environment variables were added to the container:
POLARIS_FEATURES_ALLOW_OPTIMIZED_SIBLING_CHECK: 'true',
POLARIS_FEATURES_OPTIMIZED_SIBLING_CHECK: 'true',
POLARIS_FEATURES_REALM_OVERRIDES_POLARIS_ALLOW_TABLE_LOCATION_OVERLAP: 'true'

However, none of these were picked up by Polaris at runtime.

When the equivalent flags were added directly to application.properties, they worked as expected:

polaris.features.ALLOW_OPTIMIZED_SIBLING_CHECK=true
polaris.features.OPTIMIZED_SIBLING_CHECK=true
polaris.features.realm-overrides.POLARIS.ALLOW_TABLE_LOCATION_OVERLAP=true

To Reproduce

No response

Actual Behavior

No response

Expected Behavior

No response

Additional context

No response

System information

No response

[dimas-b]

Polaris docs have some suggestions on this: https://polaris.apache.org/in-dev/unreleased/configuration/

In general, AFAIK, upper case env. variables do not have the same expressive power as java system properties or application.properties entries.

[dimas-b]

Suggestion: If using helm, use the same name for env. vars as you'd put into application.properties.

If using bash, do not try export use env instead, e.g. env 'polaris.features."ALLOW_TABLE_LOCATION_OVERLAP"=true' java ... -jar ...

[MonkeyCanCode]

@davidweimapbox mind try out the above solution mentioned by @dimas-b ? This limitation is mentioned as following:

While convenient, uppercase-only environment variables can be problematic for complex property names. In these situations, it’s preferable to use system properties or a configuration file.

[adutra]

HI, just in case, here are the rules that SmallRye Config applies to environment variables names:

https://smallrye.io/smallrye-config/Main/config/environment-variables/

Since polaris.features is a map of strings, you could maybe try the following names:

POLARIS_FEATURES__ALLOW_OPTIMIZED_SIBLING_CHECK_
POLARIS_FEATURES__OPTIMIZED_SIBLING_CHECK_
POLARIS_FEATURES__REALM_OVERRIDES_POLARIS_ALLOW_TABLE_LOCATION_OVERLAP_