Skip to content

Commit 3f510c6

Browse files
committed
[improve][ml] Improve cache insert performance by removing exists check since it's already covered by putIfAbsent (#24699)
(cherry picked from commit 669ab61)
1 parent 4097ce0 commit 3f510c6

File tree

1 file changed

+1
-6
lines changed

1 file changed

+1
-6
lines changed

managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/cache/RangeEntryCacheImpl.java

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -139,12 +139,6 @@ public boolean insert(Entry entry) {
139139
entryLength);
140140
}
141141

142-
Position position = entry.getPosition();
143-
if (entries.exists(position)) {
144-
// If the entry is already in the cache, don't insert it again
145-
return false;
146-
}
147-
148142
ByteBuf cachedData;
149143
if (copyEntries) {
150144
cachedData = copyEntry(entry);
@@ -156,6 +150,7 @@ public boolean insert(Entry entry) {
156150
cachedData = entry.getDataBuffer().retain();
157151
}
158152

153+
Position position = entry.getPosition();
159154
ReferenceCountedEntry cacheEntry =
160155
EntryImpl.createWithRetainedDuplicate(position, cachedData, entry.getReadCountHandler());
161156
cachedData.release();

0 commit comments

Comments
 (0)