[fix][test] Fix flaky PrometheusMetricsTest.testBrokerMetrics (#24042)

pdolif · lhotari · commit c4af9e635063 · 2025-03-17T09:50:41.000+02:00
(cherry picked from commit 694969f)
diff --git a/pulsar-broker/src/test/java/org/apache/pulsar/broker/stats/PrometheusMetricsTest.java b/pulsar-broker/src/test/java/org/apache/pulsar/broker/stats/PrometheusMetricsTest.java
@@ -302,8 +302,7 @@ public void testBrokerMetrics() throws Exception {
 
         double systemCursorOutBytes = 0.0;
         for (Metric metric : topicLevelBytesOutTotal) {
-            if (metric.tags.get("subscription").startsWith(SystemTopicNames.SYSTEM_READER_PREFIX)
-                    || metric.tags.get("subscription").equals(Compactor.COMPACTION_SUBSCRIPTION)) {
+            if (metric.tags.get("subscription").startsWith(SystemTopicNames.SYSTEM_READER_PREFIX)) {
                 systemCursorOutBytes = metric.value;
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -302,8 +302,7 @@ public void testBrokerMetrics() throws Exception {`
`302`	`302`
`303`	`303`	`double systemCursorOutBytes = 0.0;`
`304`	`304`	`for (Metric metric : topicLevelBytesOutTotal) {`
`305`		`- if (metric.tags.get("subscription").startsWith(SystemTopicNames.SYSTEM_READER_PREFIX)`
`306`		`- \|\| metric.tags.get("subscription").equals(Compactor.COMPACTION_SUBSCRIPTION)) {`
	`305`	`+ if (metric.tags.get("subscription").startsWith(SystemTopicNames.SYSTEM_READER_PREFIX)) {`
`307`	`306`	`systemCursorOutBytes = metric.value;`
`308`	`307`	`}`
`309`	`308`	`}`