[fix][client] Fix building broken batched message when publishing #24061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poorbarcode
added
type/bug
poorbarcode
requested review from
merlimat,
lhotari,
Technoboy-,
codelipenghui,
gaoran10 and
shibd
|
@poorbarcode Please add the following content to your PR description and select a checkbox: |
github-actions
bot
added
doc-not-needed
lhotari
reviewed
Mar 6, 2025
pulsar-client/src/main/java/org/apache/pulsar/client/impl/BatchMessageContainerImpl.java
Show resolved
Hide resolved
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerImpl.java
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #24061 +/- ##
============================================
+ Coverage 73.57% 74.23% +0.65%
+ Complexity 32624 32041 -583
============================================
Files 1877 1862 -15
Lines 139502 144232 +4730
Branches 15299 16433 +1134
============================================
+ Hits 102638 107066 +4428
+ Misses 28908 28712 -196
- Partials 7956 8454 +498
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
codelipenghui
approved these changes
Mar 7, 2025
|
@lhotari Could you take a look again? |
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Mar 21, 2025
…ache#24061) (cherry picked from commit c75018a) (cherry picked from commit 038810d)
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Mar 21, 2025
…ache#24061) (cherry picked from commit c75018a) (cherry picked from commit 038810d)
nodece
pushed a commit
to nodece/pulsar
that referenced
this pull request
Mar 27, 2025
…ache#24061) (cherry picked from commit c75018a)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Mar 29, 2025
…ache#24061) (cherry picked from commit c75018a) (cherry picked from commit ab53f2f)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Mar 31, 2025
…ache#24061) (cherry picked from commit c75018a) (cherry picked from commit ab53f2f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
1. The views of the issue:
ava.lang.IllegalArgumentException: Invalid unknown tag type: 3testNoEnoughMemSend2. The steps of issue occurs.
1msg in the container, the batched message will be built as[{msg-metadata-1}, {msg-payload}].OpSendMsgBatchMessageContainerImpl.batchedMessageMetadataAndPayloadis[{msg-metadata-1}, {msg-payload-1}]now{batch-msg-metadata}will not be appended intoBatchMessageContainerImpl.batchedMessageMetadataAndPayload, the variable will be[{msg-payload-1}]2msg in the container, the batched message will be built as[{batch-metadata}, {single-msg-metadata-1}, {msg-payload-1}, {single-msg-metadata-2}, {msg-payload-2}].BatchMessageContainerImpl.batchedMessageMetadataAndPayloadalready has some data that has not been cleared, the data actually is[{batch-metadata}, {msg-payload-1}, {single-msg-metadata-1}, {msg-payload-1}, {single-msg-metadata-2}, {msg-payload-2}]{msg-payload-1}has been read out at the first flushing, the second one will be empty, so the final data is[{batch-metadata}, {msg-payload-1},{single-msg-metadata-1}, {empty}, {single-msg-metadata-2}, {msg-payload-2}]3. Explain why it also leads to a message loss issue.
The error will also lead the batch message to be
[{batch-metadata}, {single-msg-metadata-1}, {msg-payload-1}, {single-msg-metadata-2}, {msg-payload-2}, {single-msg-metadata-1}, {empty}, {single-msg-metadata-2}, {empty}, {single-msg-metadata-3}, {msg-payload-3}]. Then themsg-3will be discarded because the value ofbatch-metadata.numChunksFromMsgis3, but there are5single message metadata.4. Error that we encountered
bin/pulsar-admin topics get-message-by-id -l 2310013 -e 57 <topic name>Modifications
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: x