-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][client] PIP-409 retry/dead letter topic producer config don't take effect. #24071
Conversation
pulsar-broker/src/test/java/org/apache/pulsar/client/api/DeadLetterTopicTest.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/test/java/org/apache/pulsar/client/api/DeadLetterTopicTest.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #24071 +/- ##
============================================
+ Coverage 73.57% 74.16% +0.58%
+ Complexity 32624 2379 -30245
============================================
Files 1877 1863 -14
Lines 139502 144297 +4795
Branches 15299 16459 +1160
============================================
+ Hits 102638 107015 +4377
+ Misses 28908 28828 -80
- Partials 7956 8454 +498
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Motivation
#24020 support configure the producer of retry/dead-letter topic, but it don't take effect.
Modifications
Make sure the config is used.
Verifying this change
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: thetumbled#73