Skip to content

Commit a078432

Browse files
committed
Update comments
1 parent d48bcc9 commit a078432

2 files changed

Lines changed: 4 additions & 1 deletion

File tree

ratis-server/src/test/java/org/apache/ratis/LinearizableReadTests.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -88,6 +88,9 @@ public void setup() {
8888
RaftServerConfigKeys.Read.setOption(p, LINEARIZABLE);
8989
RaftServerConfigKeys.Read.setLeaderLeaseEnabled(p, isLeaderLeaseEnabled());
9090
RaftServerConfigKeys.Read.ReadIndex.setType(p, readIndexType());
91+
// Disable dummy request since currently the request is implemented as a watch request
92+
// which can cause follower client to trigger failover to leader which will cause the
93+
// all reads to be sent to the leader, making the follower read moot.
9194
RaftClientConfigKeys.Async.Experimental.setSendDummyRequest(p, false);
9295
}
9396

ratis-test/src/test/java/org/apache/ratis/grpc/TestLinearizableReadRepliedIndexWithGrpc.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ static <C extends MiniRaftCluster> void runTestFollowerReadOnlyParallelRepliedIn
6969
try (RaftClient leaderClient = cluster.createClient(leader.getId());
7070
RaftClient f0Client = cluster.createClient(f0);
7171
RaftClient f1Client = cluster.createClient(f1)) {
72-
// Warm up the clients first
72+
// Warm up the clients first before blocking the reply flusher
7373
assertReplyExact(0, leaderClient.async().sendReadOnly(QUERY).get());
7474
assertReplyExact(0, f0Client.async().sendReadOnly(QUERY, f0).get());
7575
assertReplyExact(0, f1Client.async().sendReadOnly(QUERY, f1).get());

0 commit comments

Comments
 (0)