Skip to content

Commit ab3fdf9

Browse files
authored
Enable message tracing in default mode (#388)
1 parent 9959686 commit ab3fdf9

File tree

4 files changed

+9
-2
lines changed

4 files changed

+9
-2
lines changed

src/main/cpp/client/include/ClientConfig.h

+2
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,8 @@ class ClientConfig {
4545
virtual const std::string& getGroupName() const = 0;
4646

4747
virtual std::string clientId() const = 0;
48+
49+
virtual bool isTracingEnabled() const = 0;
4850
};
4951

5052
ROCKETMQ_NAMESPACE_END

src/main/cpp/client/include/ClientConfigImpl.h

+3-2
Original file line numberDiff line numberDiff line change
@@ -70,9 +70,10 @@ class ClientConfigImpl : virtual public ClientConfig {
7070
long_polling_timeout_ = timeout;
7171
}
7272

73-
bool isTracingEnabled() {
73+
bool isTracingEnabled() const override {
7474
return enable_tracing_.load();
7575
}
76+
7677
void enableTracing(bool enabled) {
7778
enable_tracing_.store(enabled);
7879
}
@@ -137,7 +138,7 @@ class ClientConfigImpl : virtual public ClientConfig {
137138

138139
absl::Duration long_polling_timeout_;
139140

140-
std::atomic<bool> enable_tracing_{false};
141+
std::atomic<bool> enable_tracing_{true};
141142

142143
static std::string steadyName();
143144
};

src/main/cpp/client/mocks/include/ClientConfigMock.h

+1
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ class ClientConfigMock : virtual public ClientConfig {
3333
MOCK_METHOD(absl::Duration, getLongPollingTimeout, (), (const override));
3434
MOCK_METHOD(const std::string&, getGroupName, (), (const override));
3535
MOCK_METHOD(std::string, clientId, (), (const override));
36+
MOCK_METHOD(bool, isTracingEnabled, (), (const override));
3637
};
3738

3839
ROCKETMQ_NAMESPACE_END

src/main/cpp/tracing/exporters/include/OtlpExporter.h

+3
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,9 @@ class OtlpExporter : public std::enable_shared_from_this<OtlpExporter> {
5656
public:
5757
OtlpExporter(std::weak_ptr<ClientManager> client_manager, ClientConfig* client_config)
5858
: client_manager_(std::move(client_manager)), client_config_(client_config) {
59+
if (client_config_->isTracingEnabled()) {
60+
mode_ = TraceMode::Grpc;
61+
}
5962
}
6063

6164
void updateHosts(std::vector<std::string> hosts) LOCKS_EXCLUDED(hosts_mtx_) {

0 commit comments

Comments
 (0)