Skip to content

Remove duplicate code in TopicPublishInfo #6398

Open
@zyx333

Description

@zyx333

The code block below in the selectOneMessageQueue method is identical to another overloaded method (2nd code block).

int index = this.sendWhichQueue.incrementAndGet();
int pos = index % this.messageQueueList.size();
MessageQueue mq = this.messageQueueList.get(pos);

public MessageQueue selectOneMessageQueue() {
int index = this.sendWhichQueue.incrementAndGet();
int pos = index % this.messageQueueList.size();
return this.messageQueueList.get(pos);
}

IMO, it can be rewritten like this.

for (int i = 0; i < this.messageQueueList.size(); i++) {
         MessageQueue mq = selectOneMessageQueue()
         if (!mq.getBrokerName().equals(lastBrokerName)) {
               return mq;
         }
 }

If it's acceptable, I will submit a pull request.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions