-
Notifications
You must be signed in to change notification settings - Fork 12k
Description
Before Creating the Bug Report
-
I found a bug, not just asking a question, which should be created in GitHub Discussions.
-
I have searched the GitHub Issues and GitHub Discussions of this repository and believe that this is not a duplicate.
-
I have confirmed that this bug belongs to the current repository, not other repositories of RocketMQ.
Runtime platform environment
macos
RocketMQ version
5.3.4
JDK Version
1.8
Describe the Bug
dashboard 可以创建 PolicyType 为Default 类型的acl,但是 mqadmin 删除acl的时候 无法指定 PolicyType,再加上mqadmin 和 dashboard都不强制 源ip 地址,dashboard遇到ip为 null 现在有bug,最坏情况就是在dashboard 创建了 Default 类型,并且没设置ip地址的acl,之后dashboard ACL Permissions页面就彻底挂了
Steps to Reproduce
打开dashboard 创建 Default 类型的 acl
What Did You Expect to See?
dashboard 是否应该禁止创建 Default 类型的 acl,或者 mqadmin 支持删除 Default 类型的acl
What Did You See Instead?
无法删除 PolicyType为Default 的 acl
Additional Context
创建 requestHeader 的时候就没传递 PolicyType
https://github.com/apache/rocketmq/blob/rocketmq-all-5.3.4/client/src/main/java/org/apache/rocketmq/client/impl/MQClientAPIImpl.java#L3552
当前没有设置 policyType 的时候 设置的是 CUSTOM
https://github.com/apache/rocketmq/blob/rocketmq-all-5.3.4/auth/src/main/java/org/apache/rocketmq/auth/authorization/manager/AuthorizationMetadataManagerImpl.java#L141