[ISSUE #9254] Refactor CQ-related in DefaultMessageStorage #9256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #9256 +/- ##
=============================================
+ Coverage 48.11% 48.22% +0.10%
- Complexity 12110 12229 +119
=============================================
Files 1322 1324 +2
Lines 93126 93576 +450
Branches 11940 12023 +83
=============================================
+ Hits 44812 45126 +314
- Misses 42775 42872 +97
- Partials 5539 5578 +39 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
qianye1001
changed the title
qianye1001
changed the title
qianye1001
changed the title
qianye1001
force-pushed
the
Refactor-DefaultMessageStore
branch
2 times, most recently
from
ad190f2 to
61ee2f4
Compare
qianye1001
force-pushed
the
Refactor-DefaultMessageStore
branch
2 times, most recently
from
dc014b5 to
a8996fa
Compare
lizhimins
reviewed
Apr 16, 2025
qianye1001
force-pushed
the
Refactor-DefaultMessageStore
branch
from
da78405 to
59ee17a
Compare
lizhimins
reviewed
Apr 18, 2025
store/src/main/java/org/apache/rocketmq/store/queue/CombineConsumeQueueStore.java
Outdated
Show resolved
Hide resolved
lizhimins
reviewed
Apr 18, 2025
store/src/main/java/org/apache/rocketmq/store/queue/CombineConsumeQueueStore.java
Outdated
Show resolved
Hide resolved
lizhimins
reviewed
Apr 18, 2025
store/src/main/java/org/apache/rocketmq/store/queue/ConsumeQueueStore.java
Outdated
Show resolved
Hide resolved
lizhimins
reviewed
Apr 18, 2025
store/src/main/java/org/apache/rocketmq/store/queue/ConsumeQueueStore.java
Show resolved
Hide resolved
lizhimins
reviewed
Apr 18, 2025
store/src/main/java/org/apache/rocketmq/store/queue/ConsumeQueueStore.java
Outdated
Show resolved
Hide resolved
lollipopjin
reviewed
Apr 21, 2025
broker/src/main/java/org/apache/rocketmq/broker/processor/AdminBrokerProcessor.java
Outdated
Show resolved
Hide resolved
lollipopjin
reviewed
Apr 22, 2025
lollipopjin
reviewed
Apr 22, 2025
lollipopjin
reviewed
Apr 22, 2025
store/src/main/java/org/apache/rocketmq/store/dledger/DLedgerCommitLog.java
Show resolved
Hide resolved
lollipopjin
reviewed
Apr 22, 2025
store/src/main/java/org/apache/rocketmq/store/metrics/RocksDBStoreMetricsManager.java
Show resolved
Hide resolved
lollipopjin
reviewed
Apr 22, 2025
store/src/main/java/org/apache/rocketmq/store/queue/CombineConsumeQueueStore.java
Outdated
Show resolved
Hide resolved
lollipopjin
reviewed
Apr 22, 2025
store/src/main/java/org/apache/rocketmq/store/queue/CombineConsumeQueueStore.java
Outdated
Show resolved
Hide resolved
lollipopjin
reviewed
Apr 22, 2025
store/src/main/java/org/apache/rocketmq/store/queue/CombineConsumeQueueStore.java
Outdated
Show resolved
Hide resolved
lollipopjin
reviewed
Apr 22, 2025
store/src/main/java/org/apache/rocketmq/store/queue/ConsumeQueueStore.java
Show resolved
Hide resolved
lollipopjin
reviewed
Apr 22, 2025
store/src/main/java/org/apache/rocketmq/store/queue/RocksDBConsumeQueue.java
Show resolved
Hide resolved
lollipopjin
reviewed
Apr 22, 2025
| return this.consumeQueueStore.getMinOffsetInQueue(topic, queueId); | ||
| } catch (RocksDBException e) { | ||
| ERROR_LOG.error("getMinOffsetInQueue Failed. topic: {}, queueId: {}", topic, queueId, e); | ||
| return -1; |
There was a problem hiding this comment.
To make sure here the default value is -1, but not 0.
lollipopjin
reviewed
Apr 22, 2025
| @@ -480,4 +486,21 @@ public CqUnit nextAndRelease() { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| public void initializeWithOffset(long offset) { | |||
There was a problem hiding this comment.
This is used for mount --> main in container mode? If so, add some java docs here.
|
|
||
| // update the max and min offset | ||
| if (offset > 0) { | ||
| this.consumeQueueStore.updateCqOffset(topic, queueId, 0L, offset - 1, true); |
There was a problem hiding this comment.
How about use two methods for updating CQ offset for min and max offsets.
store/src/main/java/org/apache/rocketmq/store/queue/RocksDBConsumeQueueStore.java
Show resolved
Hide resolved
store/src/main/java/org/apache/rocketmq/store/queue/RocksDBConsumeQueueStore.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Fixes #9254
Brief Description
How Did You Test This Change?