modify: create a new object avoid to share SrcFieldSpec

Author: loupipalien

seatunnel-transforms-v2/src/main/java/org/apache/seatunnel/transform/nlpmodel/embedding/SrcField.java

@@ -17,12 +17,16 @@
 
 package org.apache.seatunnel.transform.nlpmodel.embedding;
 
+import org.apache.seatunnel.transform.nlpmodel.embedding.multimodal.ModalityType;
+
 import lombok.Data;
+import lombok.extern.slf4j.Slf4j;
 
 import java.io.Serializable;
 import java.util.Base64;
 
 @Data
+@Slf4j
 public class SrcField implements Serializable {
 
     private static final long serialVersionUID = 1L;
@@ -32,8 +36,31 @@ public class SrcField implements Serializable {
     private Object fieldValue;
 
     public SrcField(SrcFieldSpec spec, Object value) {
-        this.fieldSpec = spec;
+        // create a new object avoid to mutate original src field spec
+        this.fieldSpec =
+                new SrcFieldSpec(
+                        spec.getFieldName(), spec.getModalityType(), spec.getPayloadFormat());
         this.fieldValue = value;
+        determineModalityType();
+    }
+
+    /**
+     * Determine the actual modality type based on field spec and value If not binary format,
+     * analyze the value suffix to determine modality type
+     */
+    private void determineModalityType() {
+        if (fieldSpec.isBinary()) {
+            return;
+        }
+        if (fieldValue != null) {
+            String valueStr = fieldValue.toString();
+            ModalityType detectedType = ModalityType.fromFileSuffix(valueStr);
+            if (detectedType != null) {
+                log.debug(
+                        "Auto-detected modality type '{}' from value: {}", detectedType, valueStr);
+                fieldSpec.setModalityType(detectedType);
+            }
+        }
     }
 
     public String toBase64() {

seatunnel-transforms-v2/src/main/java/org/apache/seatunnel/transform/nlpmodel/embedding/SrcFieldSpec.java

@@ -81,6 +81,12 @@ public SrcFieldSpec(Map<String, Object> fieldConfig) {
         }
     }
 
+    public SrcFieldSpec(String fieldName, ModalityType modalityType, PayloadFormat payloadFormat) {
+        this.fieldName = fieldName;
+        this.modalityType = modalityType;
+        this.payloadFormat = payloadFormat;
+    }
+
     public boolean isBinary() {
         return PayloadFormat.BINARY.equals(payloadFormat);
     }

seatunnel-transforms-v2/src/main/java/org/apache/seatunnel/transform/nlpmodel/embedding/multimodal/MultimodalFieldValue.java

@@ -18,15 +18,12 @@
 package org.apache.seatunnel.transform.nlpmodel.embedding.multimodal;
 
 import org.apache.seatunnel.transform.nlpmodel.embedding.SrcField;
-import org.apache.seatunnel.transform.nlpmodel.embedding.SrcFieldSpec;
 
 import lombok.Getter;
-import lombok.extern.slf4j.Slf4j;
 
 import java.io.Serializable;
 import java.util.List;
 
-@Slf4j
 @Getter
 public class MultimodalFieldValue implements Serializable {
 
@@ -36,30 +33,5 @@ public class MultimodalFieldValue implements Serializable {
 
     public MultimodalFieldValue(List<SrcField> srcFields) {
         this.srcFields = srcFields;
-        for (SrcField srcField : srcFields) {
-            SrcFieldSpec fieldSpec = srcField.getFieldSpec();
-            ModalityType modalityType = determineModalityType(fieldSpec, srcField.getFieldValue());
-            fieldSpec.setModalityType(modalityType);
-        }
-    }
-
-    /**
-     * Determine the actual modality type based on field spec and value If not binary format,
-     * analyze the value suffix to determine modality type
-     */
-    private ModalityType determineModalityType(SrcFieldSpec fieldSpec, Object fieldValue) {
-        if (fieldSpec.isBinary()) {
-            return fieldSpec.getModalityType();
-        }
-        if (fieldValue != null) {
-            String valueStr = fieldValue.toString();
-            ModalityType detectedType = ModalityType.fromFileSuffix(valueStr);
-            if (detectedType != null) {
-                log.debug(
-                        "Auto-detected modality type '{}' from value: {}", detectedType, valueStr);
-                return detectedType;
-            }
-        }
-        return fieldSpec.getModalityType();
     }
 }