You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The previous projection test covered both .las and .laz; the rewrite only covers .las. Since LAZ goes through a separate decode path, it'd be good to keep the .laz assertion (or parameterize over both).
LasSource::new(extension, table_schema: impl Into<TableSchema>) is an unrelated public-API change. Worth pulling out into a separate PR (or dropping) so this one is purely a fix.
The field reordering in LasSource and LasOpener is noisy in the diff without changing behaviour; reverting it would make the fix easier to cherry-pick.
A couple of suggestions before merging:
Tests
projectiontest covered both.lasand.laz; the rewrite only covers.las. Since LAZ goes through a separate decode path, it'd be good to keep the.lazassertion (or parameterize over both).assert_eq!on a value (e.g.classification = 0for the single point inextra.las) would lock that down.Scope
LasSource::new(extension, table_schema: impl Into<TableSchema>)is an unrelated public-API change. Worth pulling out into a separate PR (or dropping) so this one is purely a fix.LasSourceandLasOpeneris noisy in the diff without changing behaviour; reverting it would make the fix easier to cherry-pick.Originally posted by @jiayuasu in #825 (comment)