Skip to content

Commit 944fd32

Browse files
authored
Fix AlterViewFederationMetaDataRefresher (#34512)
* Fix AlterViewFederationMetaDataRefresher * Fix AlterViewFederationMetaDataRefresher
1 parent ce4218f commit 944fd32

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

mode/core/src/main/java/org/apache/shardingsphere/mode/metadata/refresher/metadata/federation/type/AlterViewFederationMetaDataRefresher.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ public void refresh(final MetaDataManagerPersistService metaDataManagerPersistSe
4848
droppedViews.add(viewName);
4949
}
5050
sqlStatement.getViewDefinition().ifPresent(optional -> alteredViews.add(new ShardingSphereView(viewName, optional)));
51-
metaDataManagerPersistService.alterSchema(database.getName(), schemaName, null, Collections.emptyList(), alteredViews, droppedViews, Collections.emptyList());
51+
metaDataManagerPersistService.alterSchema(database.getName(), schemaName, null, Collections.emptyList(), alteredViews, Collections.emptyList(), droppedViews);
5252
}
5353

5454
@Override

mode/type/standalone/core/src/main/java/org/apache/shardingsphere/mode/manager/standalone/persist/service/StandaloneMetaDataManagerPersistService.java

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@
3939
import org.apache.shardingsphere.mode.metadata.manager.SwitchingResource;
4040
import org.apache.shardingsphere.mode.metadata.persist.MetaDataPersistService;
4141
import org.apache.shardingsphere.mode.metadata.persist.config.database.DataSourceUnitPersistService;
42+
import org.apache.shardingsphere.mode.metadata.persist.metadata.DatabaseMetaDataPersistFacade;
4243
import org.apache.shardingsphere.mode.metadata.refresher.metadata.util.TableRefreshUtils;
4344
import org.apache.shardingsphere.mode.persist.service.MetaDataManagerPersistService;
4445
import org.apache.shardingsphere.mode.spi.rule.item.RuleChangedItem;
@@ -96,10 +97,11 @@ public void createSchema(final String databaseName, final String schemaName) {
9697
public void alterSchema(final String databaseName, final String schemaName, final String logicDataSourceName,
9798
final Collection<ShardingSphereTable> alteredTables, final Collection<ShardingSphereView> alteredViews,
9899
final Collection<String> droppedTables, final Collection<String> droppedViews) {
99-
metaDataPersistService.getDatabaseMetaDataFacade().getTable().persist(databaseName, schemaName, alteredTables);
100-
metaDataPersistService.getDatabaseMetaDataFacade().getView().persist(databaseName, schemaName, alteredViews);
101-
droppedTables.forEach(each -> metaDataPersistService.getDatabaseMetaDataFacade().getTable().drop(databaseName, schemaName, each));
102-
droppedViews.forEach(each -> metaDataPersistService.getDatabaseMetaDataFacade().getView().delete(databaseName, schemaName, each));
100+
DatabaseMetaDataPersistFacade databaseMetaDataFacade = metaDataPersistService.getDatabaseMetaDataFacade();
101+
databaseMetaDataFacade.getTable().persist(databaseName, schemaName, alteredTables);
102+
databaseMetaDataFacade.getView().persist(databaseName, schemaName, alteredViews);
103+
droppedTables.forEach(each -> databaseMetaDataFacade.getTable().drop(databaseName, schemaName, each));
104+
droppedViews.forEach(each -> databaseMetaDataFacade.getView().delete(databaseName, schemaName, each));
103105
ShardingSphereMetaData metaData = metaDataContextManager.getMetaDataContexts().getMetaData();
104106
ShardingSphereDatabase database = metaData.getDatabase(databaseName);
105107
addDataNode(database, logicDataSourceName, schemaName, alteredTables, alteredViews);

0 commit comments

Comments
 (0)