Skip to content

Commit d718596

Browse files
authored
Move DatabaseChangedListenerAssistedPersistService to cluster-core module (#34484)
1 parent 6955e38 commit d718596

File tree

8 files changed

+9
-17
lines changed

8 files changed

+9
-17
lines changed

mode/core/src/main/java/org/apache/shardingsphere/mode/persist/PersistServiceFacade.java

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -21,16 +21,15 @@
2121
import org.apache.shardingsphere.infra.config.mode.ModeConfiguration;
2222
import org.apache.shardingsphere.infra.instance.ComputeNodeInstance;
2323
import org.apache.shardingsphere.infra.spi.type.typed.TypedSPILoader;
24-
import org.apache.shardingsphere.mode.metadata.persist.MetaDataPersistService;
2524
import org.apache.shardingsphere.mode.metadata.MetaDataContextManager;
25+
import org.apache.shardingsphere.mode.metadata.persist.MetaDataPersistService;
2626
import org.apache.shardingsphere.mode.persist.service.MetaDataManagerPersistService;
2727
import org.apache.shardingsphere.mode.persist.service.PersistServiceBuilder;
2828
import org.apache.shardingsphere.mode.persist.service.ProcessPersistService;
29+
import org.apache.shardingsphere.mode.spi.repository.PersistRepository;
30+
import org.apache.shardingsphere.mode.state.cluster.ClusterStatePersistService;
2931
import org.apache.shardingsphere.mode.state.node.ComputeNodePersistService;
30-
import org.apache.shardingsphere.mode.state.database.DatabaseChangedListenerAssistedPersistService;
3132
import org.apache.shardingsphere.mode.state.node.QualifiedDataSourceStatePersistService;
32-
import org.apache.shardingsphere.mode.state.cluster.ClusterStatePersistService;
33-
import org.apache.shardingsphere.mode.spi.repository.PersistRepository;
3433

3534
/**
3635
* Persist service facade.
@@ -50,8 +49,6 @@ public final class PersistServiceFacade {
5049

5150
private final ProcessPersistService processPersistService;
5251

53-
private final DatabaseChangedListenerAssistedPersistService databaseChangedListenerAssistedPersistService;
54-
5552
private final QualifiedDataSourceStatePersistService qualifiedDataSourceStatePersistService;
5653

5754
public PersistServiceFacade(final PersistRepository repository, final ModeConfiguration modeConfig, final MetaDataContextManager metaDataContextManager) {
@@ -63,7 +60,6 @@ public PersistServiceFacade(final PersistRepository repository, final ModeConfig
6360
PersistServiceBuilder persistServiceBuilder = TypedSPILoader.getService(PersistServiceBuilder.class, modeConfig.getType());
6461
metaDataManagerPersistService = persistServiceBuilder.buildMetaDataManagerPersistService(repository, metaDataContextManager);
6562
processPersistService = persistServiceBuilder.buildProcessPersistService(repository);
66-
databaseChangedListenerAssistedPersistService = new DatabaseChangedListenerAssistedPersistService(repository);
6763
}
6864

6965
/**

mode/type/cluster/core/src/main/java/org/apache/shardingsphere/mode/manager/cluster/dispatch/handler/global/DatabaseChangedListenerAssistedChangedHandler.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,8 @@
2727
import org.apache.shardingsphere.mode.node.path.metadata.DatabaseMetaDataNodePath;
2828
import org.apache.shardingsphere.mode.node.path.state.StatesNodePath;
2929
import org.apache.shardingsphere.mode.repository.cluster.ClusterPersistRepository;
30-
import org.apache.shardingsphere.mode.state.database.DatabaseChangedListenerAssistedPersistService;
31-
import org.apache.shardingsphere.mode.state.database.DatabaseChangedListenerAssistedType;
30+
import org.apache.shardingsphere.mode.manager.cluster.persist.service.DatabaseChangedListenerAssistedPersistService;
31+
import org.apache.shardingsphere.mode.manager.cluster.persist.service.DatabaseChangedListenerAssistedType;
3232

3333
import java.util.Arrays;
3434
import java.util.Collection;

mode/type/cluster/core/src/main/java/org/apache/shardingsphere/mode/manager/cluster/persist/service/ClusterMetaDataManagerPersistService.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,6 @@
3838
import org.apache.shardingsphere.mode.metadata.persist.metadata.DatabaseMetaDataPersistFacade;
3939
import org.apache.shardingsphere.mode.persist.service.MetaDataManagerPersistService;
4040
import org.apache.shardingsphere.mode.spi.repository.PersistRepository;
41-
import org.apache.shardingsphere.mode.state.database.DatabaseChangedListenerAssistedPersistService;
42-
import org.apache.shardingsphere.mode.state.database.DatabaseChangedListenerAssistedType;
4341
import org.apache.shardingsphere.single.config.SingleRuleConfiguration;
4442
import org.apache.shardingsphere.single.rule.SingleRule;
4543

mode/core/src/main/java/org/apache/shardingsphere/mode/state/database/DatabaseChangedListenerAssistedPersistService.java renamed to mode/type/cluster/core/src/main/java/org/apache/shardingsphere/mode/manager/cluster/persist/service/DatabaseChangedListenerAssistedPersistService.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
* limitations under the License.
1616
*/
1717

18-
package org.apache.shardingsphere.mode.state.database;
18+
package org.apache.shardingsphere.mode.manager.cluster.persist.service;
1919

2020
import lombok.RequiredArgsConstructor;
2121
import org.apache.shardingsphere.mode.node.path.state.StatesNodePath;

mode/core/src/main/java/org/apache/shardingsphere/mode/state/database/DatabaseChangedListenerAssistedType.java renamed to mode/type/cluster/core/src/main/java/org/apache/shardingsphere/mode/manager/cluster/persist/service/DatabaseChangedListenerAssistedType.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
* limitations under the License.
1616
*/
1717

18-
package org.apache.shardingsphere.mode.state.database;
18+
package org.apache.shardingsphere.mode.manager.cluster.persist.service;
1919

2020
/**
2121
* Database changed listener assisted type.

mode/type/cluster/core/src/test/java/org/apache/shardingsphere/mode/manager/cluster/dispatch/handler/global/DatabaseChangedListenerAssistedChangedHandlerTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ void setUp() {
6363
@Test
6464
void assertHandleWithoutDatabase() {
6565
handler.handle(contextManager, new DataChangedEvent("/states/listener_assisted", "", Type.ADDED));
66-
verify(contextManager.getPersistServiceFacade(), times(0)).getDatabaseChangedListenerAssistedPersistService();
66+
verify(contextManager.getPersistServiceFacade(), times(0)).getRepository();
6767
}
6868

6969
@Test

mode/type/cluster/core/src/test/java/org/apache/shardingsphere/mode/manager/cluster/persist/service/ClusterMetaDataManagerPersistServiceTest.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,6 @@
2525
import org.apache.shardingsphere.mode.metadata.MetaDataContextManager;
2626
import org.apache.shardingsphere.mode.metadata.persist.MetaDataPersistService;
2727
import org.apache.shardingsphere.mode.spi.repository.PersistRepository;
28-
import org.apache.shardingsphere.mode.state.database.DatabaseChangedListenerAssistedPersistService;
29-
import org.apache.shardingsphere.mode.state.database.DatabaseChangedListenerAssistedType;
3028
import org.apache.shardingsphere.single.config.SingleRuleConfiguration;
3129
import org.apache.shardingsphere.single.rule.SingleRule;
3230
import org.junit.jupiter.api.BeforeEach;

mode/core/src/test/java/org/apache/shardingsphere/mode/state/database/DatabaseChangedListenerAssistedPersistServiceTest.java renamed to mode/type/cluster/core/src/test/java/org/apache/shardingsphere/mode/manager/cluster/persist/service/DatabaseChangedListenerAssistedPersistServiceTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
* limitations under the License.
1616
*/
1717

18-
package org.apache.shardingsphere.mode.state.database;
18+
package org.apache.shardingsphere.mode.manager.cluster.persist.service;
1919

2020
import org.apache.shardingsphere.mode.spi.repository.PersistRepository;
2121
import org.junit.jupiter.api.Test;

0 commit comments

Comments
 (0)