[SWCK]Why swck listen pods update event

[lphu]

swck listened for the create and update events of PODs, but did not set idempotent in the /mutate-v1-pod interface, which resulted in some scenarios updating PODs (such as adding region/zone annotations), swck will repeatedly execute the injection process, causing PODs to fail to start normally.

Wanna to understand the necessity of listenning updating event , even if an update is made, it also need to restart the Java process to make it attach again.

[wu-sheng]

The behaviors of the agent are defined through the values of system env variables, I believe watching the events makes sense.

[wu-sheng]

@innerpeacez @dashanji Could you reccheck?

[dashanji]

@lphu Thanks for reporting the problem. Actually, the current design is only for the Create event. As you said, the permission and the logic of the webhook are not idempotent. We could delete the Update event simply or achieve the update logic in the webhook.

BTW, Could you please clarify why need to update the injected pod rather than create a new one?

[lphu]

Sometimes we may patch annotations such as Region or Instance ID after the Pod scheduling is completed. You can see example here. Ali ECI

[dashanji]

@lphu I see, thanks for the details. Would you want to propose a PR to achieve the update logic in the webhook?