apm-toolkit-meter doesnt work

[9029HIME]

Version Info:

skywalking-jdk:jdk17
skywalking-apm:9.4.0
java-agent:9.0.0
application jdk:jdk8
apm-toolkit-meter dependency:9.0.0

I have put a custom meter file in apache-skywalking-apm-bin/config/meter-analyzer-config/business_success_count.yaml like this:

expSuffix: instance(['service'], ['instance'], Layer.GENERAL)
metricPrefix: meter
metricsRules:
  - name: business_success_count
    exp: business_success_count.increase("PT1M")

and I have modifed application.yaml like this:

meterAnalyzerActiveFiles: ${SW_METER_ANALYZER_ACTIVE_FILES:datasource,threadpool,satellite,go-runtime,python-runtime,business_success_count}

after starting skywalking, I found that there was a table named meter_business_success_count in the databases, as I inserted one record into this table manually and that showed on UI:

But After executing the following code, there was no any record was inserted into table:

@GetMapping("/test")
    public RestResult test(){
        String name = "meter_business_success_count";
        Counter counter = MeterFactory.counter(new MeterId (name,MeterId.MeterType.COUNTER))
                .mode(Counter.Mode.INCREMENT).build();
        counter.increment(10D);
        logger.info("after：{}:{}", counter.getName(),counter.get());
        return RestResult.success();
    }

I am sure that apm-toolkit-meter-activation-9.0.0 was loaded into JVM according to following logs:

main AgentClassLoader : D:\apache-skywalking-java-agent-9.0.0\skywalking-agent\activations\apm-toolkit-meter-activation-9.0.0.jar loaded.

find skywalking plugin define in jar:file:D:\apache-skywalking-java-agent-9.0.0\skywalking-agent\activations\apm-toolkit-meter-activation-9.0.0.jar!/skywalking-plugin.def

I have tried to find some relevant documents and issues, but I have no idea about clearing my question. Is there anything I have ignored?
Thank you for your analysis and help.

[wu-sheng]

You are creating a counter repeatedly? You should keep created counter once and use it later.

[9029HIME]

Thank you for your analysis.

I could be wrong, but I just changed my code structure to this:

private Counter counter = MeterFactory.counter(new MeterId("meter_business_success_count",MeterId.MeterType.COUNTER))
            .mode(Counter.Mode.INCREMENT).build();

@GetMapping("/test")
public RestResult test(){
    counter.increment(10D);
    logger.info("after：{}:{}", counter.getName(),counter.get());
    return RestResult.success();
}

But after executing for 15 times, it still didnt work while other metric like service_instance_sla was uploaded to sw server and recalculated:

Maybe it is not due to repetitive creation?

[wu-sheng]

Read this, https://github.com/apache/skywalking-java/blob/bc7447a2c2de1c6f11ba8bd6f35dd64a2c474746/apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/meter/MeterService.java#L64

If you created repeated, the meaningful ref would be lost inevitably.

[9029HIME]

Thank you so much for the link you found for me, I just changed my code to that create counter only once, as I mentioned in my previous reply.

But it still doesnt take effect after requesting /test for many times.

[wu-sheng]

Then you have to debug on your own. I don't have more to share.

[9029HIME]

Many thanks