Repository navigation
Commit 099c3ee
[SPARK-59688][SQL][FOLLOWUP] Cover a left outer join in the coinciding-partition-keys test
**What changes were proposed in this pull request?**
A follow-up test for SPARK-59688. It parameterizes the existing end-to-end test over an inner and a LEFT OUTER join, on the same identity(id) vs flip_low_bit(id) setup. Test only, no production change.
**Why are the changes needed?**
The end-to-end test in SPARK-59688 covers an inner join, where the wrong result is missing rows (0 of 2). An outer join hits the same coinciding-keys bug with a different symptom: it keeps the left rows and null-extends them, returning (0, 'a', null) instead of (0, 'a', 'x'). Every left row here has a match, so both join types share the expected rows, the plan assertions, and the test body. The assertions fail on a revert of the fix and pass with it.
**Does this PR introduce any user-facing change?**
No. Test only.
**How was this patch tested?**
The parameterized test. It fails on a revert of the partitioning.scala fix and passes with it. KeyGroupedPartitioningSuite runs green (195 tests).
**Was this patch authored or co-authored using generative AI tooling?**
No
Closes #59129 from naveenp2708/SPARK-59688-outer-join-test.
Authored-by: naveenp2708 <naveenp2708@gmail.com>
Signed-off-by: Szehon Ho <szehon.apache@gmail.com>1 parent 25a9aa7 commit 099c3ee
1 file changed
Lines changed: 25 additions & 16 deletions
Lines changed: 25 additions & 16 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1410 | 1410 | | |
1411 | 1411 | | |
1412 | 1412 | | |
| 1413 | + | |
| 1414 | + | |
| 1415 | + | |
1413 | 1416 | | |
1414 | 1417 | | |
1415 | 1418 | | |
1416 | 1419 | | |
1417 | 1420 | | |
1418 | 1421 | | |
1419 | 1422 | | |
1420 | | - | |
1421 | | - | |
| 1423 | + | |
| 1424 | + | |
| 1425 | + | |
| 1426 | + | |
| 1427 | + | |
1422 | 1428 | | |
1423 | | - | |
1424 | | - | |
1425 | | - | |
1426 | | - | |
1427 | | - | |
1428 | | - | |
1429 | | - | |
1430 | | - | |
1431 | | - | |
1432 | | - | |
1433 | | - | |
1434 | | - | |
1435 | | - | |
1436 | | - | |
| 1429 | + | |
| 1430 | + | |
| 1431 | + | |
| 1432 | + | |
| 1433 | + | |
| 1434 | + | |
| 1435 | + | |
| 1436 | + | |
| 1437 | + | |
| 1438 | + | |
| 1439 | + | |
| 1440 | + | |
| 1441 | + | |
| 1442 | + | |
| 1443 | + | |
| 1444 | + | |
| 1445 | + | |
1437 | 1446 | | |
1438 | 1447 | | |
1439 | 1448 | | |
| |||
0 commit comments