Skip to content

Commit d2cb444

Browse files
kusalkkusalk
committed
WW-5376 Fix BOM leaking unrelated dependencies
1 parent 077e985 commit d2cb444

File tree

8 files changed

+340
-398
lines changed

8 files changed

+340
-398
lines changed

‎apps/pom.xml

+1-2
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525
<groupId>org.apache.struts</groupId>
2626
<artifactId>struts2-parent</artifactId>
2727
<version>7.0.4-SNAPSHOT</version>
28+
<relativePath>../parent/pom.xml</relativePath>
2829
</parent>
2930
<artifactId>struts2-apps</artifactId>
3031
<packaging>pom</packaging>
@@ -93,9 +94,7 @@
9394
<dependency>
9495
<groupId>org.apache.struts</groupId>
9596
<artifactId>struts2-core</artifactId>
96-
<version>${project.version}</version>
9797
</dependency>
98-
9998
<dependency>
10099
<groupId>org.springframework</groupId>
101100
<artifactId>spring-test</artifactId>

‎assembly/pom.xml

+1
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525
<groupId>org.apache.struts</groupId>
2626
<artifactId>struts2-parent</artifactId>
2727
<version>7.0.4-SNAPSHOT</version>
28+
<relativePath>../parent/pom.xml</relativePath>
2829
</parent>
2930

3031
<artifactId>struts2-assembly</artifactId>

‎bom/pom.xml

+27-44
Original file line numberDiff line numberDiff line change
@@ -19,32 +19,22 @@
1919
* under the License.
2020
*/
2121
-->
22-
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
22+
<project xmlns="http://maven.apache.org/POM/4.0.0"
23+
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
24+
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
2325
<modelVersion>4.0.0</modelVersion>
24-
2526
<parent>
2627
<groupId>org.apache.struts</groupId>
27-
<artifactId>struts2-parent</artifactId>
28+
<artifactId>struts2-project</artifactId>
2829
<version>7.0.4-SNAPSHOT</version>
2930
</parent>
3031

3132
<artifactId>struts2-bom</artifactId>
32-
<version>7.0.4-SNAPSHOT</version>
3333
<packaging>pom</packaging>
34-
35-
<name>Struts 2 Bill of Materials</name>
36-
<description>Struts 2 Bill of Materials</description>
37-
38-
<licenses>
39-
<license>
40-
<name>The Apache Software License, Version 2.0</name>
41-
<url>http://www.apache.org/licenses/LICENSE-2.0.txt</url>
42-
<distribution>repo</distribution>
43-
</license>
44-
</licenses>
34+
<name>Struts BOM</name>
35+
<description>Struts Bill of Materials (BOM)</description>
4536

4637
<properties>
47-
<struts-version.version>7.0.4-SNAPSHOT</struts-version.version>
4838
<maven.site.skip>true</maven.site.skip>
4939
<maven.site.deploy.skip>true</maven.site.deploy.skip>
5040
</properties>
@@ -54,115 +44,108 @@
5444
<dependency>
5545
<groupId>org.apache.struts</groupId>
5646
<artifactId>struts2-core</artifactId>
57-
<version>${struts-version.version}</version>
47+
<version>${project.version}</version>
5848
</dependency>
5949
<dependency>
6050
<groupId>org.apache.struts</groupId>
6151
<artifactId>struts2-async-plugin</artifactId>
62-
<version>${struts-version.version}</version>
52+
<version>${project.version}</version>
6353
</dependency>
6454
<dependency>
6555
<groupId>org.apache.struts</groupId>
6656
<artifactId>struts2-bean-validation-plugin</artifactId>
67-
<version>${struts-version.version}</version>
57+
<version>${project.version}</version>
6858
</dependency>
6959
<dependency>
7060
<groupId>org.apache.struts</groupId>
7161
<artifactId>struts2-cdi-plugin</artifactId>
72-
<version>${struts-version.version}</version>
62+
<version>${project.version}</version>
7363
</dependency>
7464
<dependency>
7565
<groupId>org.apache.struts</groupId>
7666
<artifactId>struts2-convention-plugin</artifactId>
77-
<version>${struts-version.version}</version>
67+
<version>${project.version}</version>
7868
</dependency>
7969
<dependency>
8070
<groupId>org.apache.struts</groupId>
8171
<artifactId>struts2-config-browser-plugin</artifactId>
82-
<version>${struts-version.version}</version>
72+
<version>${project.version}</version>
8373
</dependency>
8474
<dependency>
8575
<groupId>org.apache.struts</groupId>
8676
<artifactId>struts2-embeddedjsp-plugin</artifactId>
87-
<version>${struts-version.version}</version>
77+
<version>${project.version}</version>
8878
</dependency>
8979
<dependency>
9080
<groupId>org.apache.struts</groupId>
9181
<artifactId>struts2-gxp-plugin</artifactId>
92-
<version>${struts-version.version}</version>
82+
<version>${project.version}</version>
9383
</dependency>
9484
<dependency>
9585
<groupId>org.apache.struts</groupId>
9686
<artifactId>struts2-jasperreports-plugin</artifactId>
97-
<version>${struts-version.version}</version>
87+
<version>${project.version}</version>
9888
</dependency>
9989
<dependency>
10090
<groupId>org.apache.struts</groupId>
10191
<artifactId>struts2-javatemplates-plugin</artifactId>
102-
<version>${struts-version.version}</version>
92+
<version>${project.version}</version>
10393
</dependency>
10494
<dependency>
10595
<groupId>org.apache.struts</groupId>
10696
<artifactId>struts2-jfreechart-plugin</artifactId>
107-
<version>${struts-version.version}</version>
97+
<version>${project.version}</version>
10898
</dependency>
10999
<dependency>
110100
<groupId>org.apache.struts</groupId>
111101
<artifactId>struts2-json-plugin</artifactId>
112-
<version>${struts-version.version}</version>
102+
<version>${project.version}</version>
113103
</dependency>
114104
<dependency>
115105
<groupId>org.apache.struts</groupId>
116106
<artifactId>struts2-junit-plugin</artifactId>
117-
<version>${struts-version.version}</version>
107+
<version>${project.version}</version>
118108
</dependency>
119109
<dependency>
120110
<groupId>org.apache.struts</groupId>
121111
<artifactId>struts2-osgi-plugin</artifactId>
122-
<version>${struts-version.version}</version>
112+
<version>${project.version}</version>
123113
</dependency>
124114
<dependency>
125115
<groupId>org.apache.struts</groupId>
126116
<artifactId>struts2-plexus-plugin</artifactId>
127-
<version>${struts-version.version}</version>
117+
<version>${project.version}</version>
128118
</dependency>
129119
<dependency>
130120
<groupId>org.apache.struts</groupId>
131121
<artifactId>struts2-rest-plugin</artifactId>
132-
<version>${struts-version.version}</version>
122+
<version>${project.version}</version>
133123
</dependency>
134124
<dependency>
135125
<groupId>org.apache.struts</groupId>
136126
<artifactId>struts2-spring-plugin</artifactId>
137-
<version>${struts-version.version}</version>
127+
<version>${project.version}</version>
138128
</dependency>
139129
<dependency>
140130
<groupId>org.apache.struts</groupId>
141131
<artifactId>struts2-testng-plugin</artifactId>
142-
<version>${struts-version.version}</version>
132+
<version>${project.version}</version>
143133
</dependency>
144134
<dependency>
145135
<groupId>org.apache.struts</groupId>
146136
<artifactId>struts2-tiles-plugin</artifactId>
147-
<version>${struts-version.version}</version>
137+
<version>${project.version}</version>
148138
</dependency>
149139
<dependency>
150140
<groupId>org.apache.struts</groupId>
151141
<artifactId>struts2-velocity-plugin</artifactId>
152-
<version>${struts-version.version}</version>
142+
<version>${project.version}</version>
153143
</dependency>
154144
<dependency>
155145
<groupId>org.apache.struts</groupId>
156146
<artifactId>struts2-xslt-plugin</artifactId>
157-
<version>${struts-version.version}</version>
147+
<version>${project.version}</version>
158148
</dependency>
159149
</dependencies>
160150
</dependencyManagement>
161-
162-
<scm>
163-
<tag>HEAD</tag>
164-
<connection>scm:git:https://gitbox.apache.org/repos/asf/struts.git</connection>
165-
<developerConnection>scm:git:https://gitbox.apache.org/repos/asf/struts.git</developerConnection>
166-
<url>https://github.com/apache/struts/</url>
167-
</scm>
168151
</project>

‎core/pom.xml

+1
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525
<groupId>org.apache.struts</groupId>
2626
<artifactId>struts2-parent</artifactId>
2727
<version>7.0.4-SNAPSHOT</version>
28+
<relativePath>../parent/pom.xml</relativePath>
2829
</parent>
2930
<artifactId>struts2-core</artifactId>
3031
<packaging>jar</packaging>

‎jakarta/pom.xml

+1
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525
<groupId>org.apache.struts</groupId>
2626
<artifactId>struts2-parent</artifactId>
2727
<version>7.0.4-SNAPSHOT</version>
28+
<relativePath>../parent/pom.xml</relativePath>
2829
</parent>
2930
<artifactId>struts2-jakarta</artifactId>
3031
<packaging>pom</packaging>

0 commit comments

Comments
 (0)