Skip to content

Commit 05bbab3

Browse files
committed
fix(dashboard): resolve dropdown popup positioning
1 parent 84279ac commit 05bbab3

File tree

2 files changed

+12
-1
lines changed

2 files changed

+12
-1
lines changed

superset-frontend/packages/superset-ui-core/src/components/Select/Select.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,7 @@ import {
6363
} from './styles';
6464
import {
6565
DEFAULT_SORT_COMPARATOR,
66+
DROPDOWN_ALIGN_BOTTOM,
6667
EMPTY_OPTIONS,
6768
MAX_TAG_COUNT,
6869
TOKEN_SEPARATORS,
@@ -776,6 +777,7 @@ const Select = forwardRef(
776777
optionRender={option => <Space>{option.label || option.value}</Space>}
777778
oneLine={oneLine}
778779
css={props.css}
780+
dropdownAlign={DROPDOWN_ALIGN_BOTTOM}
779781
{...props}
780782
showSearch={shouldShowSearch}
781783
ref={ref}

superset-frontend/packages/superset-ui-core/src/components/Select/constants.ts

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,11 @@
1616
* specific language governing permissions and limitations
1717
* under the License.
1818
*/
19-
import { LabeledValue as AntdLabeledValue } from 'antd/es/select';
19+
import Select, { LabeledValue as AntdLabeledValue } from 'antd/es/select';
2020
import { t } from '@superset-ui/core';
2121
import { rankedSearchCompare } from '../../utils/rankedSearchCompare';
2222
import { RawValue } from './types';
23+
import { ComponentProps } from 'react';
2324

2425
export const MAX_TAG_COUNT = 4;
2526

@@ -33,6 +34,14 @@ export const SELECT_ALL_VALUE: RawValue = t('Select All');
3334

3435
export const VIRTUAL_THRESHOLD = 20;
3536

37+
export const DROPDOWN_ALIGN_BOTTOM: ComponentProps<
38+
typeof Select
39+
>['dropdownAlign'] = {
40+
points: ['tl', 'bl'],
41+
offset: [0, 4],
42+
overflow: { adjustX: 0, adjustY: 1 },
43+
};
44+
3645
export const SELECT_ALL_OPTION = {
3746
value: SELECT_ALL_VALUE,
3847
label: String(SELECT_ALL_VALUE),

0 commit comments

Comments
 (0)