Open
Description
Please refer to SIP-139 #29268.
The Tabs
component should be upgraded to Ant Design version 5.
Similar work has been completed here.
IMPORTANT:
- The
src/components/Tabs
must be upgraded to Ant Design 5. - All direct imports of Tabs should be refactored to use
src/components/Tabs
instead. - All components importing AntdTabs from
superset-frontend/src/components/index.ts
should also be refactored to usesrc/components/Tabs
.
When upgrading the component to Ant Design 5, please ensure to include:
- Remove unnecessary custom styles. We want to go as vanilla Ant Design as possible.
- Proper RTL test coverage if not present yet.
- A Storybook file (if not present) or all necessary changes.
- Include all relevant component options in the Storybook.
When opening a PR:
- Name your PR refactor({Component}): Upgrade {component} to Ant Design 5
- Add screenshots of BEFORE/AFTER in your PR.
- Update the project tracker when your PR is merged.
- Make sure you or a committer has labeled your PR with frontend:refactor:antd5.