Skip to content

Can't upload spreadsheets with capitalized extensions .XLSX and .CSV #32654

Open
@sfirke

Description

@sfirke

Bug description

Running 5.0.0rc1, try to upload a spreadsheet with a capitalized extension and it causes an error:

Image

It's a bummer that I get sent files like this but they are still valid files.

Superset version

master / latest-dev

Python version

I don't know

Node version

I don't know

Browser

Chrome

Additional context

I think the fix goes here: https://github.com/apache/superset/blob/master/superset-frontend/src/features/databases/UploadDataModel/index.tsx#L186-L187

Have that comparison happen with both the new file and the allow list first converted to lowercase. I can't test it out to send a PR right now, anyone is welcome to pick this up.

Checklist

  • I have searched Superset docs and Slack and didn't find a solution to my problem.
  • I have searched the GitHub issue tracker and didn't find a similar bug report.
  • I have checked Superset's logs for errors and if I found a relevant Python stacktrace, I included it here as text in the "additional context" section.

Metadata

Metadata

Assignees

No one assigned

    Labels

    data:csvRelated to import/export of CSVsgood first issueGood first issues for new contributorsreview:checkpointLast PR reviewed during the daily review standup

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions