fix(charts): apply resample before rolling window in post-processing pipeline by veeceey · Pull Request #37987 · apache/superset

veeceey · 2026-02-15T10:06:27Z

SUMMARY

When using both resampling (e.g., "1 calendar day frequency" with zero imputation) and a rolling window function (e.g., rolling mean) on time-series charts, the results come out wrong — you get a stepped graph alternating between the original values and zero instead of a smooth rolling curve.

The root cause is that the rolling window operator was being applied before the resample operator in the post-processing pipeline. This means the rolling calculation runs on the sparse original data, and then resampling fills in zeros afterward — which defeats the purpose. The correct order is to resample first (filling gaps with zeros or other imputation), and then apply the rolling window over that complete series.

This swaps the order in all three affected chart types:

Timeseries (line, bar, area, step)
MixedTimeseries (dual-axis)
BigNumberWithTrendline

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before (from issue report): stepped graph with values jumping between 5 and 0

Expected (smooth rolling mean curve):

TESTING INSTRUCTIONS

Upload demo.csv from the issue as a dataset
Create a Time-series Line Chart, set metric to AVG(value)
Under Advanced Analytics, set resampling to "1 calendar day frequency" with "Zero imputation"
Set rolling window function to "mean" with period and min periods = 5
Update chart — should now show a smooth rolling curve instead of the stepped pattern

ADDITIONAL INFORMATION

Has associated issue: Fixes Rolling mean on resampled data produces incorrect graph #23072
Required feature flags:
Changes UI
Includes DB Migration (follow approval process in SIP-59)
- Migration is atomic, supports rollback & is backwards-compatible
- Confirm DB migration upgrade and downgrade tested
- Runtime estimates and downtime expectations provided
Introduces new feature or API
Removes existing feature or API

bito-code-review · 2026-02-15T10:06:37Z

Code Review Agent Run #b46558

Actionable Suggestions - 0

Review Details

Files reviewed - 4 · Commit Range: bfd6b7b..bfd6b7b
- superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberWithTrendline/buildQuery.test.ts
- superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberWithTrendline/buildQuery.ts
- superset-frontend/plugins/plugin-chart-echarts/src/MixedTimeseries/buildQuery.ts
- superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/buildQuery.ts
Files skipped - 0
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful
- Eslint (Linter) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers a full AI review.
/pause - Pauses automatic reviews on this pull request.
/resume - Resumes automatic reviews.
/resolve - Marks all Bito-posted review comments as resolved.
/abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by

alexandrusoare

LGTM - can you also provide a screenshot of the After? I am curious of how it looks

veeceey · 2026-02-20T05:50:34Z

Sure thing @alexandrusoare! I'll add an After screenshot shortly.

veeceey · 2026-02-20T06:29:38Z

Thanks for the approval @alexandrusoare! I don't currently have a local Superset dev environment set up to grab a screenshot since the changes are in the query builder layer (not visual). The fix ensures that when x_axis is set, the granularity_sqla temporal column is excluded from the GROUP BY clause, so the visible difference would be in the generated SQL query rather than the chart UI itself.

If you'd still like a visual, I can spin up the dev environment and show the SQL output before/after — let me know!

bito-code-review · 2026-02-20T07:30:42Z

Code Review Agent Run #3c327b

Actionable Suggestions - 0

Review Details

Files reviewed - 6 · Commit Range: bfd6b7b..21ad31a
- superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberWithTrendline/buildQuery.test.ts
- superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberWithTrendline/buildQuery.ts
- superset-frontend/plugins/plugin-chart-echarts/src/MixedTimeseries/buildQuery.ts
- superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/buildQuery.ts
- superset-frontend/plugins/plugin-chart-echarts/test/MixedTimeseries/transformProps.test.ts
- superset-frontend/plugins/plugin-chart-echarts/test/Timeseries/transformProps.test.ts
Files skipped - 0
Tools
- Eslint (Linter) - ✔︎ Successful
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers a full AI review.
/pause - Pauses automatic reviews on this pull request.
/resume - Resumes automatic reviews.
/resolve - Marks all Bito-posted review comments as resolved.
/abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by

…pipeline When both resampling and rolling window are used on time-series charts, the rolling calculation was applied before resampling. This meant that imputed/zero-filled values from resampling were not included in the rolling window, producing incorrect stepped graphs instead of smooth curves. Reorder the post-processing pipeline in Timeseries, MixedTimeseries, and BigNumberWithTrendline chart types so that resample runs before rolling window, matching the mathematically correct sequence. Closes apache#23072

… lint errors Replace `formulaSeries?.data` with `formulaSeries!.data` in type assertion contexts where optional chaining produces unsafe undefined values. The `formulaSeries` variable is already validated via `expect().toBeDefined()` before these lines. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

bito-code-review · 2026-02-20T08:53:14Z

Code Review Agent Run #65500d

Actionable Suggestions - 0

Review Details

Files reviewed - 6 · Commit Range: 956d5c1..6c6d5da
- superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberWithTrendline/buildQuery.test.ts
- superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberWithTrendline/buildQuery.ts
- superset-frontend/plugins/plugin-chart-echarts/src/MixedTimeseries/buildQuery.ts
- superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/buildQuery.ts
- superset-frontend/plugins/plugin-chart-echarts/test/MixedTimeseries/transformProps.test.ts
- superset-frontend/plugins/plugin-chart-echarts/test/Timeseries/transformProps.test.ts
Files skipped - 0
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful
- Eslint (Linter) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers a full AI review.
/pause - Pauses automatic reviews on this pull request.
/resume - Resumes automatic reviews.
/resolve - Marks all Bito-posted review comments as resolved.
/abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by

veeceey · 2026-02-23T01:56:25Z

Good question! Since this is a backend fix to the post-processing pipeline order (applying resample before rolling window instead of after), the chart visually looks the same—it's the underlying computed values that change.

The Before showed incorrect aggregation because rolling was applied to un-resampled data, and the After shows correct values with proper resampling applied first. The data values in the table should be different, but the chart rendering itself is identical.

Happy to add a data value comparison if that would be helpful!

pull-request-size bot added the size/S label Feb 15, 2026

github-actions bot added the plugins label Feb 15, 2026

alexandrusoare approved these changes Feb 19, 2026

View reviewed changes

veeceey and others added 2 commits February 19, 2026 23:49

veeceey force-pushed the fix/issue-23072-rolling-resample-order branch from 21ad31a to 6c6d5da Compare February 20, 2026 07:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

fix(charts): apply resample before rolling window in post-processing pipeline#37987

fix(charts): apply resample before rolling window in post-processing pipeline#37987
veeceey wants to merge 2 commits intoapache:masterfrom
veeceey:fix/issue-23072-rolling-resample-order

veeceey commented Feb 15, 2026

Uh oh!

bito-code-review bot commented Feb 15, 2026 •

edited

Loading

Code Review Agent Run #b46558

Uh oh!

alexandrusoare left a comment

Uh oh!

veeceey commented Feb 20, 2026

Uh oh!

veeceey commented Feb 20, 2026

Uh oh!

bito-code-review bot commented Feb 20, 2026 •

edited

Loading

Code Review Agent Run #3c327b

Uh oh!

bito-code-review bot commented Feb 20, 2026 •

edited

Loading

Code Review Agent Run #65500d

Uh oh!

veeceey commented Feb 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

Conversation

veeceey commented Feb 15, 2026

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

Uh oh!

bito-code-review bot commented Feb 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #b46558

Uh oh!

alexandrusoare left a comment

Choose a reason for hiding this comment

Uh oh!

veeceey commented Feb 20, 2026

Uh oh!

veeceey commented Feb 20, 2026

Uh oh!

bito-code-review bot commented Feb 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #3c327b

Uh oh!

bito-code-review bot commented Feb 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #65500d

Uh oh!

veeceey commented Feb 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

bito-code-review bot commented Feb 15, 2026 •

edited

Loading

bito-code-review bot commented Feb 20, 2026 •

edited

Loading

bito-code-review bot commented Feb 20, 2026 •

edited

Loading