Skip to content

Commit 030ce05

Browse files
authored
TIKA-4789 -- drop solr 8, add 10 (#2951)
1 parent 87ab54b commit 030ce05

4 files changed

Lines changed: 7 additions & 13 deletions

File tree

tika-integration-tests/tika-pipes-solr-integration-tests/pom.xml

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -88,14 +88,6 @@
8888
<version>${solrj.version}</version>
8989
<scope>test</scope>
9090
</dependency>
91-
<!-- troubles on CI tika-main-jdk26 -->
92-
<dependency>
93-
<groupId>org.apache.httpcomponents</groupId>
94-
<artifactId>httpmime</artifactId>
95-
<scope>test</scope>
96-
</dependency>
97-
98-
9991
</dependencies>
10092

10193
<build>

tika-integration-tests/tika-pipes-solr-integration-tests/src/test/java/org/apache/tika/pipes/solr/tests/TikaPipesSolr8Test.java renamed to tika-integration-tests/tika-pipes-solr-integration-tests/src/test/java/org/apache/tika/pipes/solr/tests/TikaPipesSolr10Test.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,11 +19,11 @@
1919
import org.testcontainers.junit.jupiter.Testcontainers;
2020

2121
@Testcontainers(disabledWithoutDocker = true)
22-
public class TikaPipesSolr8Test extends TikaPipesSolrTestBase {
22+
public class TikaPipesSolr10Test extends TikaPipesSolrTestBase {
2323

2424
@Override
2525
public String getSolrImageName() {
26-
return "solr:8.11.4";
26+
return "solr:10.0.0";
2727
}
2828

2929
@Override

tika-integration-tests/tika-pipes-solr-integration-tests/src/test/java/org/apache/tika/pipes/solr/tests/TikaPipesSolr8ZkTest.java renamed to tika-integration-tests/tika-pipes-solr-integration-tests/src/test/java/org/apache/tika/pipes/solr/tests/TikaPipesSolr10ZkTest.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,19 +19,20 @@
1919
import static org.junit.jupiter.api.Assumptions.assumeTrue;
2020

2121
import org.junit.jupiter.api.BeforeAll;
22+
import org.junit.jupiter.api.Disabled;
2223
import org.testcontainers.junit.jupiter.Testcontainers;
2324

2425
import org.apache.tika.utils.SystemUtils;
2526

27+
@Disabled("until we can fix SessionExpiredException")
2628
@Testcontainers(disabledWithoutDocker = true)
27-
public class TikaPipesSolr8ZkTest extends TikaPipesSolr8Test {
29+
public class TikaPipesSolr10ZkTest extends TikaPipesSolr10Test {
2830

2931
@BeforeAll
3032
public static void setUp() {
3133
assumeTrue(
3234
SystemUtils.IS_OS_UNIX && !SystemUtils.IS_OS_MAC_OSX,
3335
"zk test only works on linux (and not mac os x)");
34-
3536
}
3637

3738
@Override

tika-integration-tests/tika-pipes-solr-integration-tests/src/test/java/org/apache/tika/pipes/solr/tests/TikaPipesSolrTestBase.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -180,8 +180,9 @@ protected void setupSolr(Path pipesDirectory) throws Exception {
180180
zkPort = solr.getMappedPort(9983);
181181
solrEndpoint = "http://" + solrHost + ":" + solrPort + "/solr";
182182

183+
// "create" (not the deprecated "create_collection", removed in Solr 10) works on 8/9/10
183184
org.testcontainers.containers.Container.ExecResult createResult =
184-
solr.execInContainer("/opt/solr/bin/solr", "create_collection", "-c", collection);
185+
solr.execInContainer("/opt/solr/bin/solr", "create", "-c", collection);
185186
if (createResult.getExitCode() != 0) {
186187
LOG.error("Failed to create Solr collection '{}'. Exit code: {}, stdout: {}, stderr: {}",
187188
collection, createResult.getExitCode(),

0 commit comments

Comments
 (0)