TIKA-4809: Fix needsPipesParsingHelper missing /meta after its pipes migration

Author: tballison

tika-server/tika-server-core/src/main/java/org/apache/tika/server/core/TikaServerProcess.java

@@ -185,7 +185,7 @@ private static ServerDetails initServer(TikaServerConfig tikaServerConfig) throw
         PipesParsingHelper pipesParsingHelper = null;
         if (needsPipesParsingHelper(tikaServerConfig)) {
             pipesParsingHelper = initPipesParsingHelper(tikaServerConfig);
-            LOG.info("Pipes-based parsing enabled for /tika, /rmeta, /unpack, and /pipes endpoints");
+            LOG.info("Pipes-based parsing enabled for /tika, /rmeta, /unpack, /meta, and /pipes endpoints");
         }
 
         TikaResource tikaResource = new TikaResource(tikaLoader, serverStatus, pipesParsingHelper,
@@ -456,21 +456,22 @@ private static Collection<?> loadWriterServices() {
 
     /**
      * Determines if the shared PipesParser (wrapped in PipesParsingHelper) is needed
-     * based on configured endpoints. It's needed when /tika, /rmeta, /unpack, or /pipes
-     * are enabled (either explicitly or by default) -- all four now share one parser.
-     * (Note: unlike the others, /pipes also requires allowPipes to actually start; if
-     * it's listed without allowPipes, loadCoreProviders will refuse to start regardless
-     * of whether this method already triggered building the shared parser.)
+     * based on configured endpoints. It's needed when /tika, /rmeta, /unpack, /meta, or
+     * /pipes are enabled (either explicitly or by default) -- all five now share one
+     * parser. (Note: unlike the others, /pipes also requires allowPipes to actually
+     * start; if it's listed without allowPipes, loadCoreProviders will refuse to start
+     * regardless of whether this method already triggered building the shared parser.)
      */
-    private static boolean needsPipesParsingHelper(TikaServerConfig tikaServerConfig) {
+    static boolean needsPipesParsingHelper(TikaServerConfig tikaServerConfig) {
         List<String> endpoints = tikaServerConfig.getEndpoints();
         // If no endpoints specified, all default endpoints are loaded (including
         // tika, rmeta, and unpack; pipes too when allowPipes is set)
         if (endpoints == null || endpoints.isEmpty()) {
             return true;
         }
         return endpoints.contains("tika") || endpoints.contains("rmeta")
-                || endpoints.contains("unpack") || endpoints.contains("pipes");
+                || endpoints.contains("unpack") || endpoints.contains("pipes")
+                || endpoints.contains("meta");
     }
 
     /**

tika-server/tika-server-core/src/test/java/org/apache/tika/server/core/TikaServerProcessTest.java

@@ -17,7 +17,9 @@
 package org.apache.tika.server.core;
 
 import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
+import static org.junit.jupiter.api.Assertions.assertFalse;
 import static org.junit.jupiter.api.Assertions.assertThrows;
+import static org.junit.jupiter.api.Assertions.assertTrue;
 
 import java.util.ArrayList;
 import java.util.List;
@@ -51,4 +53,13 @@ public void ordinaryEndpointIsAllowedWithoutAllowPipes() {
         assertDoesNotThrow(
                 () -> TikaServerProcess.loadCoreProviders(config(false, "meta"), null, null));
     }
+
+    @Test
+    public void metaAloneNeedsPipesParsingHelper() {
+        // /meta is now pipes-backed too; a config listing only "meta" (no tika/rmeta/
+        // unpack/pipes) must still build the shared PipesParser, or every /meta request
+        // hits IllegalStateException("Pipes-based parsing is not enabled").
+        assertTrue(TikaServerProcess.needsPipesParsingHelper(config(false, "meta")));
+        assertFalse(TikaServerProcess.needsPipesParsingHelper(config(false, "status")));
+    }
 }