TIKA-4854 - tests: assert the JPEG write succeeded, check the Numbers thumbnail's name and type

Author: dschmidt

tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-apple-module/src/test/java/org/apache/tika/parser/iwork/IWorkParserTest.java

@@ -76,8 +76,11 @@ public void testPagesThumbnail() throws Exception {
     public void testNumbersThumbnail() throws Exception {
         List<Metadata> metadataList = getRecursiveMetadata("testNumbers.numbers");
         assertEquals(2, metadataList.size());
+        Metadata thumbnail = metadataList.get(1);
+        assertEquals("QuickLook/Thumbnail.jpg", thumbnail.get(TikaCoreProperties.RESOURCE_NAME_KEY));
+        assertEquals("image/jpeg", thumbnail.get(HttpHeaders.CONTENT_TYPE));
         assertEquals(TikaCoreProperties.EmbeddedResourceType.THUMBNAIL.toString(),
-                metadataList.get(1).get(TikaCoreProperties.EMBEDDED_RESOURCE_TYPE));
+                thumbnail.get(TikaCoreProperties.EMBEDDED_RESOURCE_TYPE));
     }
 
     /**

tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-apple-module/src/test/java/org/apache/tika/parser/iwork/iwana/IWork18ParserTest.java

@@ -17,6 +17,7 @@
 package org.apache.tika.parser.iwork.iwana;
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertTrue;
 
 import java.awt.image.BufferedImage;
 import java.io.ByteArrayOutputStream;
@@ -80,7 +81,7 @@ public void testPreviewIsTheThumbnail() throws Exception {
     private static byte[] jpeg() throws Exception {
         BufferedImage image = new BufferedImage(8, 8, BufferedImage.TYPE_INT_RGB);
         ByteArrayOutputStream bos = new ByteArrayOutputStream();
-        ImageIO.write(image, "jpeg", bos);
+        assertTrue(ImageIO.write(image, "jpeg", bos), "no JPEG writer available");
         return bos.toByteArray();
     }