TIKA-4545: checkstyle and minor bug fixes

Author: tballison

tika-annotation-processor/src/main/java/org/apache/tika/annotation/TikaComponentProcessor.java

@@ -69,6 +69,7 @@ public class TikaComponentProcessor extends AbstractProcessor {
         SERVICE_INTERFACES.put("org.apache.tika.parser.Parser", "parsers");
         SERVICE_INTERFACES.put("org.apache.tika.detect.Detector", "detectors");
         SERVICE_INTERFACES.put("org.apache.tika.detect.EncodingDetector", "encoding-detectors");
+        SERVICE_INTERFACES.put("org.apache.tika.language.detect.LanguageDetector", "language-detectors");
         SERVICE_INTERFACES.put("org.apache.tika.language.translate.Translator", "translators");
         SERVICE_INTERFACES.put("org.apache.tika.renderer.Renderer", "renderers");
         SERVICE_INTERFACES.put("org.apache.tika.metadata.filter.MetadataFilter", "metadata-filters");

tika-core/src/main/java/org/apache/tika/config/ConfigBase.java

@@ -364,11 +364,8 @@ private static boolean hasChildNodes(Node param) {
     }
 
     private static void tryToSetSet(Object object, Node param) throws TikaConfigException {
-//        if (hasClass(param)) {
-  //          tryToSetClassList(object, param);
-    //    } else {
-            tryToSetStringSet(object, param);
-      //  }
+        //simple hack for now -- only handle Set<String>
+        tryToSetStringSet(object, param);
     }
 
     private static void tryToSetStringSet(Object object, Node param) throws TikaConfigException {

tika-core/src/main/java/org/apache/tika/detect/OverrideEncodingDetector.java

@@ -23,7 +23,6 @@
 import java.nio.charset.StandardCharsets;
 
 import org.apache.tika.config.ConfigDeserializer;
-import org.apache.tika.config.Field;
 import org.apache.tika.config.JsonConfig;
 import org.apache.tika.config.TikaComponent;
 import org.apache.tika.metadata.Metadata;

tika-core/src/main/java/org/apache/tika/extractor/RUnpackExtractorFactory.java

@@ -18,7 +18,6 @@
 
 import java.util.Collections;
 import java.util.HashSet;
-import java.util.List;
 import java.util.Set;
 
 import org.apache.tika.config.Field;

tika-core/src/main/java/org/apache/tika/metadata/writefilter/StandardWriteFilterFactory.java

@@ -17,7 +17,6 @@
 package org.apache.tika.metadata.writefilter;
 
 import java.util.Collections;
-import java.util.List;
 import java.util.Set;
 import java.util.concurrent.ConcurrentHashMap;
 

tika-core/src/main/java/org/apache/tika/parser/AutoDetectParser.java

@@ -37,7 +37,6 @@
 import org.apache.tika.metadata.TikaCoreProperties;
 import org.apache.tika.mime.MediaType;
 import org.apache.tika.mime.MediaTypeRegistry;
-import org.apache.tika.mime.MimeTypes;
 import org.apache.tika.sax.SecureContentHandler;
 
 public class AutoDetectParser extends CompositeParser {

tika-grpc/src/main/java/org/apache/tika/pipes/grpc/TikaGrpcServerImpl.java

@@ -22,7 +22,6 @@
 import java.lang.reflect.InvocationTargetException;
 import java.nio.charset.StandardCharsets;
 import java.nio.file.Files;
-import java.nio.file.Paths;
 import java.util.HashMap;
 import java.util.LinkedHashMap;
 import java.util.List;

tika-langdetect/tika-langdetect-opennlp/src/main/java/org/apache/tika/langdetect/opennlp/OpenNLPDetector.java

@@ -32,6 +32,7 @@
 import opennlp.tools.util.normalizer.ShrinkCharSequenceNormalizer;
 import opennlp.tools.util.normalizer.TwitterCharSequenceNormalizer;
 
+import org.apache.tika.config.TikaComponent;
 import org.apache.tika.language.detect.LanguageConfidence;
 import org.apache.tika.language.detect.LanguageDetector;
 import org.apache.tika.language.detect.LanguageResult;
@@ -78,6 +79,7 @@
  * Language Resources and Evaluation Conference (LREC), p. 4003-4012,
  * May 2020, pdf, bib.
  */
+@TikaComponent
 public class OpenNLPDetector extends LanguageDetector {
 
     static LanguageDetectorModel LANG_MODEL;

tika-langdetect/tika-langdetect-optimaize/src/main/java/org/apache/tika/langdetect/optimaize/OptimaizeLangDetector.java

@@ -35,6 +35,7 @@
 import com.optimaize.langdetect.profiles.LanguageProfile;
 import com.optimaize.langdetect.profiles.LanguageProfileReader;
 
+import org.apache.tika.config.TikaComponent;
 import org.apache.tika.language.detect.LanguageConfidence;
 import org.apache.tika.language.detect.LanguageDetector;
 import org.apache.tika.language.detect.LanguageNames;
@@ -44,6 +45,7 @@
  * Implementation of the LanguageDetector API that uses
  * https://github.com/optimaize/language-detector
  */
+@TikaComponent
 public class OptimaizeLangDetector extends LanguageDetector {
 
     private static final List<LanguageProfile> DEFAULT_LANGUAGE_PROFILES;

tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-ocr-module/src/main/java/org/apache/tika/parser/ocr/TesseractOCRConfig.java

@@ -17,12 +17,8 @@
 package org.apache.tika.parser.ocr;
 
 import java.io.Serializable;
-import java.lang.reflect.Field;
-import java.lang.reflect.Modifier;
-import java.util.ArrayList;
 import java.util.HashMap;
 import java.util.HashSet;
-import java.util.List;
 import java.util.Locale;
 import java.util.Map;
 import java.util.Set;
@@ -32,11 +28,7 @@
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
-import org.apache.tika.config.ConfigDeserializer;
-import org.apache.tika.config.JsonConfig;
-import org.apache.tika.config.TikaConfig;
 import org.apache.tika.exception.TikaConfigException;
-import org.apache.tika.exception.TikaException;
 import org.apache.tika.utils.StringUtils;
 
 /**