TIKA-4753 -- doc style clean up

Author: tballison

docs/modules/ROOT/pages/using-tika/server/index.adoc

@@ -164,11 +164,13 @@ JSON body whose shape matches the `PipesResult` status:
 
 [source,json]
 ----
-{"status": "TIMEOUT", "message": "Task timed out after 60000ms"}
+{"status": "TIMEOUT"}
 ----
 
-The `status` field is the `PipesResult.RESULT_STATUS` enum name. The `message` field is
-present when Tika provided one, absent otherwise.
+The `status` field is the `PipesResult.RESULT_STATUS` enum name. By default the body
+carries only the `status`. When the server is configured with `returnStackTrace=true`,
+a `message` field is also included (it often contains a server-side stack trace), e.g.
+`{"status": "TIMEOUT", "message": "Task timed out after 60000ms"}`.
 
 [cols="1,1,3"]
 |===
@@ -190,8 +192,8 @@ document on the same server is unlikely to succeed without a configuration fix.
 
 NOTE: A successful parse that encountered internal parser errors (e.g. a truncated
 embedded document) still returns `200 OK`. The partial-parse exception is surfaced
-in the `X-TIKA:CONTAINER_EXCEPTION` metadata field of the response, not as an HTTP
-error code.
+in the `X-TIKA:EXCEPTION:container_exception` metadata field of the response, not as an
+HTTP error code.
 
 == Configuration
 

tika-server/tika-server-core/src/main/java/org/apache/tika/server/core/TikaServerProcess.java

@@ -510,7 +510,7 @@ private static PipesParsingHelper initPipesParsingHelper(TikaServerConfig tikaSe
 
         // Create and return the helper
         PipesParsingHelper helper = new PipesParsingHelper(pipesParser, pipesConfig,
-                inputTempDirectory, unpackTempDirectory);
+                inputTempDirectory, unpackTempDirectory, tikaServerConfig.isReturnStackTrace());
 
         // Register shutdown hook to clean up PipesParser and temp directories
         final Path inputDirToClean = inputTempDirectory;

tika-server/tika-server-core/src/main/java/org/apache/tika/server/core/resource/PipesParsingHelper.java

@@ -70,6 +70,7 @@ public class PipesParsingHelper {
     private final PipesConfig pipesConfig;
     private final Path inputTempDirectory;
     private final Path unpackEmitterBasePath;
+    private final boolean returnStackTrace;
 
     /**
      * Creates a PipesParsingHelper.
@@ -81,13 +82,19 @@ public class PipesParsingHelper {
      * @param unpackEmitterBasePath the basePath where the unpack-emitter writes files.
      *                              This is where the server will find the zip files created
      *                              by UNPACK mode. May be null if UNPACK mode won't be used.
+     * @param returnStackTrace whether failure responses may include the (potentially
+     *                         stack-trace-bearing) {@code PipesResult} message. When false
+     *                         (the default), error bodies carry only the status. Mirrors
+     *                         {@code TikaServerConfig.isReturnStackTrace()}.
      */
     public PipesParsingHelper(PipesParser pipesParser, PipesConfig pipesConfig,
-                              Path inputTempDirectory, Path unpackEmitterBasePath) {
+                              Path inputTempDirectory, Path unpackEmitterBasePath,
+                              boolean returnStackTrace) {
         this.pipesParser = pipesParser;
         this.pipesConfig = pipesConfig;
         this.inputTempDirectory = inputTempDirectory;
         this.unpackEmitterBasePath = unpackEmitterBasePath;
+        this.returnStackTrace = returnStackTrace;
 
         if (inputTempDirectory == null || !Files.isDirectory(inputTempDirectory)) {
             throw new IllegalArgumentException(
@@ -189,18 +196,21 @@ private String getSuffix(Metadata metadata) {
 
     /**
      * Builds a JSON error response carrying a subset of the {@code PipesResult}
-     * serialization — the {@code status} and, when present, a non-blank {@code message}:
-     * {@code {"status": "TIMEOUT", "message": "..."}}. Successful-parse fields such as
-     * {@code emitData} are never part of an error body.
+     * serialization. By default the body is just {@code {"status": "TIMEOUT"}}. The
+     * {@code PipesResult} message frequently contains a server-side stack trace
+     * (e.g. for {@code *_EXCEPTION} statuses), so the {@code message} field is included
+     * only when {@code returnStackTrace} is enabled — matching the legacy
+     * {@code TikaServerParseExceptionMapper}, which gates stack traces the same way.
+     * Successful-parse fields such as {@code emitData} are never part of an error body.
      * <p>
      * This allows clients to distinguish failure modes (TIMEOUT, OOM, UNSPECIFIED_CRASH, …)
      * without parsing plain-text bodies or inspecting custom headers.
      */
-    private static Response buildProcessFailureResponse(PipesResult result) {
+    private Response buildProcessFailureResponse(PipesResult result) {
         ObjectMapper mapper = new ObjectMapper();
         ObjectNode node = mapper.createObjectNode();
         node.put("status", result.status().name());
-        if (result.message() != null && !result.message().isBlank()) {
+        if (returnStackTrace && result.message() != null && !result.message().isBlank()) {
             node.put("message", result.message());
         }
         String json;

tika-server/tika-server-core/src/test/java/org/apache/tika/server/core/CXFTestBase.java

@@ -214,7 +214,7 @@ public void setUp() throws Exception {
             pipesConfig.setEmitStrategy(new EmitStrategyConfig(EmitStrategy.PASSBACK_ALL));
             this.pipesParser = PipesParser.load(tikaJsonConfig, pipesConfig, this.pipesConfigPath);
             PipesParsingHelper pipesParsingHelper = new PipesParsingHelper(this.pipesParser, pipesConfig,
-                    inputTempDirectory, getUnpackEmitterBasePath());
+                    inputTempDirectory, getUnpackEmitterBasePath(), false);
 
             TikaResource.init(tika, new ServerStatus(), pipesParsingHelper, isEnableUnsecureFeatures());
         } finally {