TIKA-4490 (#2349) -- fixes for problems found via ossfuzz integration

Author: tballison

tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-mail-module/src/main/java/org/apache/tika/parser/mail/MailContentHandler.java

@@ -128,6 +128,10 @@ public void body(BodyDescriptor body, InputStream is) throws MimeException, IOEx
         if (!extractAllAlternatives && alternativePartBuffer.size() > 0) {
             UnsynchronizedByteArrayOutputStream bos = UnsynchronizedByteArrayOutputStream.builder().get();
             IOUtils.copy(is, bos);
+            byte[] bytes = bos.toByteArray();
+            if (bytes.length == 0) {
+                return;
+            }
             alternativePartBuffer.peek().children.add(new BodyContents(submd, bos.toByteArray()));
         } else if (!extractAllAlternatives && parts.size() < 2) {
             //if you're at the first level of embedding
@@ -137,6 +141,9 @@ public void body(BodyDescriptor body, InputStream is) throws MimeException, IOEx
             UnsynchronizedByteArrayOutputStream bos = UnsynchronizedByteArrayOutputStream.builder().get();
             IOUtils.copy(is, bos);
             final byte[] bytes = bos.toByteArray();
+            if (bytes.length == 0) {
+                return;
+            }
             if (detectInlineTextOrHtml(submd, bytes)) {
                 handleInlineBodyPart(new BodyContents(submd, bytes));
             } else {

tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-microsoft-module/src/main/java/org/apache/tika/detect/microsoft/ooxml/OPCPackageDetector.java

@@ -198,6 +198,10 @@ public static MediaType detectOfficeOpenXML(OPCPackage pkg) {
 
         // Get the type of the core document part
         PackagePart corePart = pkg.getPart(core.getRelationship(0));
+        if (corePart == null) {
+            return null;
+        }
+
         String coreType = corePart.getContentType();
 
         if (coreType.contains(".xps")) {

tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-microsoft-module/src/main/java/org/apache/tika/parser/microsoft/ExcelExtractor.java

@@ -508,6 +508,9 @@ private void internalProcessRecord(Record record)
                     break;
 
                 case LabelSSTRecord.sid: // Ref. a string in the shared string table
+                    if (sstRecord == null) {
+                        throw new TikaException("sstRecord should have been initialized before a ref to the shared string table");
+                    }
                     LabelSSTRecord sst = (LabelSSTRecord) record;
                     UnicodeString unicode = sstRecord.getString(sst.getSSTIndex());
                     String cellString = null;

tika-parsers/tika-parsers-standard/tika-parsers-standard-package/src/test/java/org/apache/tika/ossfuzz/OssFuzzReplicator.java

@@ -0,0 +1,32 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.tika.ossfuzz;
+
+import org.junit.jupiter.api.Disabled;
+import org.junit.jupiter.api.Test;
+
+import org.apache.tika.parser.mail.RFC822Parser;
+
+public class OssFuzzReplicator {
+
+    @Test
+    @Disabled("turn this on for debugging ossfuzz findings")
+    public void testOne() throws Throwable {
+        byte[] bytes = new byte[0];//specify bytes here...probably from a path
+        ParserFuzzer.parseOne(new RFC822Parser(), bytes);
+    }
+}

tika-parsers/tika-parsers-standard/tika-parsers-standard-package/src/test/java/org/apache/tika/ossfuzz/ParserFuzzer.java

@@ -0,0 +1,77 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.tika.ossfuzz;
+
+import java.io.InputStream;
+
+import org.xml.sax.ContentHandler;
+
+import org.apache.tika.io.TikaInputStream;
+import org.apache.tika.metadata.Metadata;
+import org.apache.tika.parser.ParseContext;
+import org.apache.tika.parser.Parser;
+import org.apache.tika.parser.RecursiveParserWrapper;
+import org.apache.tika.sax.BasicContentHandlerFactory;
+import org.apache.tika.sax.RecursiveParserWrapperHandler;
+
+import org.apache.tika.sax.ToTextContentHandler;
+
+
+class ParserFuzzer {
+
+    public static void parseOne(Parser parser, byte[] bytes, ParseContext parseContext) throws Throwable {
+        parseBytes(parser, bytes, parseContext);
+        parseFile(parser, bytes, parseContext);
+    }
+
+
+    public static void parseOne(Parser parser, byte[] bytes) throws Throwable {
+        parseBytes(parser, bytes, new ParseContext());
+        parseFile(parser, bytes, new ParseContext());
+    }
+
+    public static void parseRMetaFile(Parser parser, byte[] bytes) throws Throwable {
+        RecursiveParserWrapper wrapper = new RecursiveParserWrapper(parser);
+        RecursiveParserWrapperHandler rpwh = new RecursiveParserWrapperHandler(
+                new BasicContentHandlerFactory(BasicContentHandlerFactory.HANDLER_TYPE.XML, -1));
+        try (TikaInputStream tis = TikaInputStream.get(bytes)) {
+            tis.getPath();
+            wrapper.parse(tis, rpwh, new Metadata(), new ParseContext());
+        }
+    }
+
+    public static void parseBytes(Parser parser, byte[] bytes, ParseContext parseContext) throws Throwable {
+        ContentHandler handler = new ToTextContentHandler();
+        //make sure that other parsers cannot be invoked
+        parseContext.set(Parser.class, parser);
+        //try first with bytes
+        try (InputStream is = TikaInputStream.get(bytes)) {
+            parser.parse(is, handler, new Metadata(), parseContext);
+        }
+    }
+
+    public static void parseFile(Parser parser, byte[] bytes, ParseContext parseContext) throws Throwable {
+        ContentHandler handler = new ToTextContentHandler();
+        //make sure that other parsers cannot be invoked
+        parseContext.set(Parser.class, parser);
+        try (TikaInputStream tis = TikaInputStream.get(bytes)) {
+            //force writing to tmp file
+            tis.getPath();
+            parser.parse(tis, handler, new Metadata(), parseContext);
+        }
+    }
+}