Skip to content

Commit 8a72343

Browse files
authored
TIKA-4553 -- rm TikaConfig from tika-example (#2435)
1 parent 1ae7e46 commit 8a72343

5 files changed

Lines changed: 28 additions & 21 deletions

File tree

tika-example/src/main/java/org/apache/tika/example/DumpTikaConfigExample.java renamed to tika-example/src/main/java/org/apache/tika/example/DumpTikaConfigExample.java.disabled

File renamed without changes.

tika-example/src/main/java/org/apache/tika/example/ExtractEmbeddedFiles.java

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,9 @@
2626
import org.xml.sax.ContentHandler;
2727
import org.xml.sax.SAXException;
2828

29-
import org.apache.tika.config.TikaConfig;
29+
import org.apache.tika.config.loader.TikaLoader;
3030
import org.apache.tika.detect.Detector;
31+
import org.apache.tika.exception.TikaConfigException;
3132
import org.apache.tika.exception.TikaException;
3233
import org.apache.tika.extractor.EmbeddedDocumentExtractor;
3334
import org.apache.tika.extractor.ParsingEmbeddedDocumentExtractor;
@@ -36,15 +37,18 @@
3637
import org.apache.tika.metadata.TikaCoreProperties;
3738
import org.apache.tika.mime.MediaType;
3839
import org.apache.tika.mime.MimeTypeException;
39-
import org.apache.tika.parser.AutoDetectParser;
4040
import org.apache.tika.parser.ParseContext;
4141
import org.apache.tika.parser.Parser;
4242
import org.apache.tika.sax.BodyContentHandler;
4343

4444
public class ExtractEmbeddedFiles {
45-
private Parser parser = new AutoDetectParser();
46-
private Detector detector = ((AutoDetectParser) parser).getDetector();
47-
private TikaConfig config = TikaConfig.getDefaultConfig();
45+
46+
private TikaLoader tikaLoader = TikaLoader.loadDefault();
47+
private Parser parser = tikaLoader.loadAutoDetectParser();
48+
private Detector detector = tikaLoader.loadDetectors();
49+
50+
public ExtractEmbeddedFiles() throws TikaConfigException, IOException {
51+
}
4852

4953
public void extract(InputStream is, Path outputDir) throws SAXException, TikaException, IOException {
5054
Metadata m = new Metadata();
@@ -97,8 +101,8 @@ public void parseEmbedded(TikaInputStream stream, ContentHandler handler, Metada
97101

98102
if (name.indexOf('.') == -1 && contentType != null) {
99103
try {
100-
name += config
101-
.getMimeRepository()
104+
name += tikaLoader
105+
.getMimeTypes()
102106
.forName(contentType.toString())
103107
.getExtension();
104108
} catch (MimeTypeException e) {

tika-example/src/main/java/org/apache/tika/example/MyFirstTika.java

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
import org.apache.commons.io.FileUtils;
2626
import org.xml.sax.ContentHandler;
2727

28-
import org.apache.tika.config.TikaConfig;
28+
import org.apache.tika.config.loader.TikaLoader;
2929
import org.apache.tika.detect.Detector;
3030
import org.apache.tika.io.TikaInputStream;
3131
import org.apache.tika.langdetect.optimaize.OptimaizeLangDetector;
@@ -50,10 +50,10 @@
5050
public class MyFirstTika {
5151
public static void main(String[] args) throws Exception {
5252
String filename = args[0];
53-
TikaConfig tikaConfig = TikaConfig.getDefaultConfig();
53+
TikaLoader tikaLoader = TikaLoader.loadDefault();
5454

5555
Metadata metadata = new Metadata();
56-
String text = parseUsingComponents(filename, tikaConfig, metadata);
56+
String text = parseUsingComponents(filename, tikaLoader, metadata);
5757
System.out.println("Parsed Metadata: ");
5858
System.out.println(metadata);
5959
System.out.println("Parsed Text: ");
@@ -62,25 +62,25 @@ public static void main(String[] args) throws Exception {
6262
System.out.println("-------------------------");
6363

6464
metadata = new Metadata();
65-
text = parseUsingAutoDetect(filename, tikaConfig, metadata);
65+
text = parseUsingAutoDetect(filename, tikaLoader, metadata);
6666
System.out.println("Parsed Metadata: ");
6767
System.out.println(metadata);
6868
System.out.println("Parsed Text: ");
6969
System.out.println(text);
7070
}
7171

72-
public static String parseUsingAutoDetect(String filename, TikaConfig tikaConfig, Metadata metadata) throws Exception {
72+
public static String parseUsingAutoDetect(String filename, TikaLoader tikaLoader, Metadata metadata) throws Exception {
7373
System.out.println("Handling using AutoDetectParser: [" + filename + "]");
7474

75-
AutoDetectParser parser = new AutoDetectParser(tikaConfig);
75+
Parser parser = tikaLoader.loadAutoDetectParser();
7676
ContentHandler handler = new BodyContentHandler();
7777
TikaInputStream stream = TikaInputStream.get(Paths.get(filename), metadata);
7878
parser.parse(stream, handler, metadata, new ParseContext());
7979
return handler.toString();
8080
}
8181

82-
public static String parseUsingComponents(String filename, TikaConfig tikaConfig, Metadata metadata) throws Exception {
83-
MimeTypes mimeRegistry = tikaConfig.getMimeRepository();
82+
public static String parseUsingComponents(String filename, TikaLoader tikaLoader, Metadata metadata) throws Exception {
83+
MimeTypes mimeRegistry = tikaLoader.getMimeTypes();
8484

8585
System.out.println("Examining: [" + filename + "]");
8686

@@ -91,7 +91,7 @@ public static String parseUsingComponents(String filename, TikaConfig tikaConfig
9191
System.out.println("The MIME type (based on MAGIC) is: [" + mimeRegistry.detect(stream, metadata) + "]");
9292

9393
stream = TikaInputStream.get(Paths.get(filename));
94-
Detector detector = tikaConfig.getDetector();
94+
Detector detector = tikaLoader.loadDetectors();
9595
System.out.println("The MIME type (based on the Detector interface) is: [" + detector.detect(stream, metadata) + "]");
9696

9797
LanguageDetector langDetector = new OptimaizeLangDetector().loadModels();
@@ -100,7 +100,7 @@ public static String parseUsingComponents(String filename, TikaConfig tikaConfig
100100
System.out.println("The language of this content is: [" + lang.getLanguage() + "]");
101101

102102
// Get a non-detecting parser that handles all the types it can
103-
Parser parser = tikaConfig.getParser();
103+
Parser parser = tikaLoader.loadParsers();
104104
// Tell it what we think the content is
105105
MediaType type = detector.detect(stream, metadata);
106106
metadata.set(Metadata.CONTENT_TYPE, type.toString());

tika-example/src/main/java/org/apache/tika/example/TranscribeTranslateExample.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
import java.nio.file.Paths;
2121

2222
import org.apache.tika.Tika;
23-
import org.apache.tika.config.TikaConfig;
23+
import org.apache.tika.config.loader.TikaLoader;
2424
import org.apache.tika.language.translate.Translator;
2525
import org.apache.tika.language.translate.impl.GoogleTranslator;
2626

@@ -69,8 +69,9 @@ public static String googleTranslateToEnglish(String text) {
6969
* @param file the name of the file (which needs to be on the Java Classpath) to transcribe.
7070
* @return transcribed text.
7171
*/
72-
public static String amazonTranscribe(Path tikaConfig, Path file) throws Exception {
73-
return new Tika(new TikaConfig(tikaConfig)).parseToString(file);
72+
public static String amazonTranscribe(Path tikaConfigPath, Path file) throws Exception {
73+
TikaLoader tikaLoader = TikaLoader.load(tikaConfigPath);
74+
return new Tika(tikaLoader.loadDetectors(), tikaLoader.loadAutoDetectParser()).parseToString(file);
7475
}
7576

7677
/**

tika-example/src/test/java/org/apache/tika/example/DumpTikaConfigExampleTest.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@
3131

3232
import org.junit.jupiter.api.AfterEach;
3333
import org.junit.jupiter.api.BeforeEach;
34+
import org.junit.jupiter.api.Disabled;
3435
import org.junit.jupiter.api.Test;
3536

3637
import org.apache.tika.config.TikaConfig;
@@ -40,6 +41,7 @@
4041
import org.apache.tika.parser.CompositeParser;
4142
import org.apache.tika.parser.Parser;
4243

44+
@Disabled
4345
public class DumpTikaConfigExampleTest {
4446
private File configFile;
4547

@@ -66,7 +68,7 @@ public void tearDown() {
6668

6769
@Test
6870
public void testDump() throws Exception {
69-
DumpTikaConfigExample ex = new DumpTikaConfigExample();
71+
//DumpTikaConfigExample ex = new DumpTikaConfigExample();
7072
for (Charset charset : new Charset[]{UTF_8, UTF_16LE}) {
7173
for (TikaConfigSerializer.Mode mode : TikaConfigSerializer.Mode.values()) {
7274
Writer writer = new OutputStreamWriter(new FileOutputStream(configFile), charset);

0 commit comments

Comments
 (0)