fix the build on windows and try to add a windows build to our github ci (#2407)

Author: tballison

.github/workflows/main-jdk17-windows-build-multi-locale.yml

@@ -0,0 +1,45 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#      http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+name: main jdk17 windows build (multi-locale)
+
+on:
+  pull_request:
+    branches: [ main ]
+  push:
+    branches: [ main ]
+
+jobs:
+  build:
+    runs-on: windows-latest
+    strategy:
+      matrix:
+        java: [ '17' ]
+        locale: [ 'tr_TR.UTF-8', 'de_DE.UTF-8' ]
+    env:
+      LANG: ${{ matrix.locale }}
+      LC_ALL: ${{ matrix.locale }}
+
+    steps:
+      - uses: actions/checkout@v4
+      - name: Set up JDK ${{ matrix.java }}
+        uses: actions/setup-java@v4
+        with:
+          distribution: 'temurin'
+          java-version: ${{ matrix.java }}
+      - name: Build with Maven
+        run: mvn clean test install javadoc:aggregate

.github/workflows/main-jdk17-windows-build.yml

@@ -0,0 +1,44 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#      http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+name: main jdk17 windows build
+
+on:
+  pull_request:
+    branches: [ main ]
+  push:
+    branches: [ main ]
+
+jobs:
+  build:
+    runs-on: windows-latest
+    strategy:
+      matrix:
+        java: [ '17' ]
+
+    steps:
+      - uses: actions/checkout@v4
+        with:
+          path: 'tika build dir'
+      - name: Set up JDK ${{ matrix.java }}
+        uses: actions/setup-java@v4
+        with:
+          distribution: 'temurin'
+          java-version: ${{ matrix.java }}
+      - name: Build with Maven
+        working-directory: 'tika build dir'
+        run: mvn clean test install javadoc:aggregate

tika-app/src/test/java/org/apache/tika/cli/TikaCLIAsyncTest.java

@@ -77,6 +77,7 @@ public static void setUpClass() throws Exception {
                         .replace("TIKA_CONFIG", ASYNC_CONFIG.toAbsolutePath().toString());
 
                 ;
+        json = json.replace("\\", "/");
         Files.writeString(ASYNC_PLUGINS_CONFIG, json, UTF_8);
     }
 

tika-app/src/test/java/org/apache/tika/cli/TikaCLITest.java

@@ -401,11 +401,9 @@ private void testRecursiveUnpack(String targetFile, String[] expectedChildrenFil
         Path pluginsDir = Paths.get("target/plugins");
 
         String[] params = {"-Z",
-                "-p", ProcessUtils.escapeCommandLine(pluginsDir.toAbsolutePath().toString()),
-                ProcessUtils.escapeCommandLine(input.toAbsolutePath().toString()),
-                ProcessUtils.escapeCommandLine(extractDir
-                .toAbsolutePath()
-                .toString())};
+                "-p", pluginsDir.toAbsolutePath().toString(),
+                input.toAbsolutePath().toString(),
+                extractDir.toAbsolutePath().toString()};
 
         TikaCLI.main(params);
 
@@ -429,7 +427,6 @@ private Set<String> getFileNames(Path extractDir) throws IOException {
                 return FileVisitResult.CONTINUE;
             }
 
-            @Override
             public @NotNull FileVisitResult visitFile(Path path, @NotNull BasicFileAttributes basicFileAttributes) throws IOException {
                 names.add(extractDir.relativize(path).toString().replace('\\', '/'));
                 return FileVisitResult.CONTINUE;

tika-eval/tika-eval-app/src/main/java/org/apache/tika/eval/app/ExtractComparerRunner.java

@@ -187,7 +187,7 @@ private static PipesIterator createIterator(Path inputDir) throws IOException {
             json = new String(is.readAllBytes(), StandardCharsets.UTF_8);
         }
         json = json.replace("FETCHER_BASE_PATH", inputDir.toAbsolutePath().toString());
-
+        json = json.replace("\\", "/");
         try {
             return FileSystemPipesIterator.build(new ExtensionConfig("", "", json));
         } catch (TikaConfigException e) {

tika-eval/tika-eval-app/src/main/java/org/apache/tika/eval/app/ExtractProfileRunner.java

@@ -181,6 +181,7 @@ private static PipesIterator createIterator(Path inputDir) throws IOException {
             json = new String(is.readAllBytes(), StandardCharsets.UTF_8);
         }
         json = json.replace("FETCHER_BASE_PATH", inputDir.toAbsolutePath().toString());
+        json = json.replace("\\", "/");
 
         try {
             return FileSystemPipesIterator.build(new ExtensionConfig("", "", json));

tika-parsers/tika-parsers-standard/tika-parsers-standard-package/pom.xml

@@ -176,11 +176,6 @@
       <version>${zstd.version}</version>
       <scope>test</scope>
     </dependency>
-    <dependency>
-      <groupId>${project.groupId}</groupId>
-      <artifactId>tika-serialization</artifactId>
-      <scope>test</scope>
-    </dependency>
     <!-- For legal reasons (incompatible license), jai-imageio-jpeg2000 is to be used
     only in the tests and may not be distributed. See also LEGAL-195 -->
     <dependency>
@@ -201,13 +196,6 @@
       <version>${project.version}</version>
       <scope>test</scope>
     </dependency>
-    <dependency>
-      <groupId>${project.groupId}</groupId>
-      <artifactId>tika-core</artifactId>
-      <version>${project.version}</version>
-      <type>test-jar</type>
-      <scope>test</scope>
-    </dependency>
     <dependency>
       <groupId>${project.groupId}</groupId>
       <artifactId>tika-parser-zip-commons</artifactId>

tika-pipes/tika-async-cli/src/main/java/org/apache/tika/async/cli/PluginsWriter.java

@@ -58,7 +58,7 @@ void write(Path output) throws IOException {
             if (Files.isDirectory(plugins)) {
                 pluginString = plugins.toAbsolutePath().toString();
             }
-            json = json.replace("PLUGIN_ROOTS", pluginString);
+            json = json.replace("PLUGIN_ROOTS", pluginString).replace("\\", "/");
             AsyncConfig asyncConfig = new AsyncConfig();
 
             asyncConfig.setNumClients(simpleAsyncConfig.getNumClients() == null ? 2 : simpleAsyncConfig.getNumClients());

tika-pipes/tika-async-cli/src/main/java/org/apache/tika/async/cli/SimpleAsyncConfig.java

@@ -91,4 +91,21 @@ public BasicContentHandlerFactory.HANDLER_TYPE getHandlerType() {
     public String getPluginsDir() {
         return pluginsDir;
     }
+
+    @Override
+    public String toString() {
+        return "SimpleAsyncConfig{" +
+                "inputDir='" + inputDir + '\'' +
+                ", outputDir='" + outputDir + '\'' +
+                ", numClients=" + numClients +
+                ", timeoutMs=" + timeoutMs +
+                ", xmx='" + xmx + '\'' +
+                ", fileList='" + fileList + '\'' +
+                ", tikaConfig='" + tikaConfig + '\'' +
+                ", asyncConfig='" + asyncConfig + '\'' +
+                ", extractBytes=" + extractBytes +
+                ", handlerType=" + handlerType +
+                ", pluginsDir='" + pluginsDir + '\'' +
+                '}';
+    }
 }

tika-pipes/tika-async-cli/src/test/java/org/apache/tika/async/cli/AsyncProcessorTest.java

@@ -99,7 +99,7 @@ public void setUp() throws Exception {
                 .replace("PLUGIN_ROOTS", pluginsDir.toAbsolutePath().toString())
                 .replace("TIKA_CONFIG", tikaConfigPath.toAbsolutePath().toString())
                 .replace("PLUGINS_CONFIG", pipesConfig.toAbsolutePath().toString());
-
+        jsonTemp = jsonTemp.replace("\\", "/");
         Files.writeString(pipesConfig, jsonTemp, StandardCharsets.UTF_8);
 
         Path mock = inputDir.resolve("mock.xml");