TIKA-4704: close client so that temp directory gets deleted (#2743)

* TIKA-4704: close client so that temp directory gets deleted

* Refactor PipesClient initialization in tests

Refactor FrictionlessUnpackTest to use try-with-resources for PipesClient initialization, reducing code duplication and improving resource management.

* Refactor try-with-resources syntax in tests

* Refactor try-with-resources syntax in tests

* Refactor testWriteLimiter methods for clarity

* Clean up comments in MetadataWriteLimiterTest

Removed redundant comments in the test case for write limiter override.

* Refactor JSON config string in testWriteLimiterOverride

Updated the JSON configuration string for ParseContext to improve readability.

* Clean up comments in MetadataWriteLimiterTest

Removed commented code regarding ParseContext override for X-TIKA:parse_time_millis.

* Update comment to reflect number of embedded documents

* Update tika-pipes/tika-pipes-integration-tests/src/test/java/org/apache/tika/pipes/core/MetadataWriteLimiterTest.java

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Close pipesClient in PassbackFilterTest

Close pipesClient after emitting data in test.

* Refactor PipesClient usage in tests to try-with-resources

* Update tika-pipes/tika-pipes-integration-tests/src/test/java/org/apache/tika/pipes/core/EmbeddedLimitsTest.java

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Refactor UnpackModeTest for improved readability

* Refactor PipesClientTest to use try-with-resources

* Refactor UnpackModeTest for clarity and structure

* Update tika-pipes/tika-pipes-integration-tests/src/test/java/org/apache/tika/pipes/core/UnpackModeTest.java

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Author: THausherr

tika-pipes/tika-pipes-integration-tests/src/test/java/org/apache/tika/pipes/core/EmbeddedLimitsTest.java

@@ -59,16 +59,15 @@ private PipesClient initWithWriteLimiter(Path tmp, String testFileName) throws E
      */
     @Test
     public void testWriteLimiterFromConfig(@TempDir Path tmp) throws Exception {
-        PipesClient pipesClient = initWithWriteLimiter(tmp, TEST_DOC);
-
-        PipesResult pipesResult = pipesClient.process(
-                new FetchEmitTuple(TEST_DOC, new FetchKey(FETCHER_NAME, TEST_DOC),
-                        new EmitKey(), new Metadata(), new ParseContext(), FetchEmitTuple.ON_PARSE_EXCEPTION.SKIP));
-
-        assertNotNull(pipesResult.emitData().getMetadataList());
-        assertEquals(1, pipesResult.emitData().getMetadataList().size());
-
-        Metadata metadata = pipesResult.emitData().getMetadataList().get(0);
+        Metadata metadata;
+        try (PipesClient pipesClient = initWithWriteLimiter(tmp, TEST_DOC)) {
+            PipesResult pipesResult = pipesClient.process(
+                    new FetchEmitTuple(TEST_DOC, new FetchKey(FETCHER_NAME, TEST_DOC),
+                            new EmitKey(), new Metadata(), new ParseContext(), FetchEmitTuple.ON_PARSE_EXCEPTION.SKIP));
+            assertNotNull(pipesResult.emitData().getMetadataList());
+            assertEquals(1, pipesResult.emitData().getMetadataList().size());
+            metadata = pipesResult.emitData().getMetadataList().get(0);
+        }
 
         // These fields should be present (in includeFields or "must add" fields)
         assertNotNull(metadata.get("Content-Type"), "Content-Type should be present");
@@ -88,31 +87,29 @@ public void testWriteLimiterFromConfig(@TempDir Path tmp) throws Exception {
      */
     @Test
     public void testWriteLimiterOverrideViaParseContext(@TempDir Path tmp) throws Exception {
-        PipesClient pipesClient = initWithWriteLimiter(tmp, TEST_DOC);
-
-        // Create a ParseContext with an override that allows X-TIKA:parse_time_millis
-        // The default config's includeFields (dc:creator, Content-Type, X-TIKA:content)
-        // does NOT include X-TIKA:parse_time_millis, but this override does.
-        ParseContext parseContext = new ParseContext();
-        String overrideJson = """
-                {
-                    "includeFields": ["Content-Type", "X-TIKA:parse_time_millis"],
-                    "maxKeySize": 100,
-                    "maxFieldSize": 1000,
-                    "maxTotalBytes": 10000,
-                    "maxValuesPerField": 5
-                }
-                """;
-        parseContext.setJsonConfig("standard-metadata-limiter-factory", () -> overrideJson);
-
-        PipesResult pipesResult = pipesClient.process(
-                new FetchEmitTuple(TEST_DOC, new FetchKey(FETCHER_NAME, TEST_DOC),
-                        new EmitKey(), new Metadata(), parseContext, FetchEmitTuple.ON_PARSE_EXCEPTION.SKIP));
-
-        assertNotNull(pipesResult.emitData().getMetadataList());
-        assertEquals(1, pipesResult.emitData().getMetadataList().size());
-
-        Metadata metadata = pipesResult.emitData().getMetadataList().get(0);
+        Metadata metadata;
+        try (PipesClient pipesClient = initWithWriteLimiter(tmp, TEST_DOC)) {
+            // Create a ParseContext with an override that allows X-TIKA:parse_time_millis
+            // The default config's includeFields (dc:creator, Content-Type, X-TIKA:content)
+            // does NOT include X-TIKA:parse_time_millis, but this override does.
+            ParseContext parseContext = new ParseContext();
+            String overrideJson = """
+                    {
+                        "includeFields": ["Content-Type", "X-TIKA:parse_time_millis"],
+                        "maxKeySize": 100,
+                        "maxFieldSize": 1000,
+                        "maxTotalBytes": 10000,
+                        "maxValuesPerField": 5
+                    }
+                    """;
+            parseContext.setJsonConfig("standard-metadata-limiter-factory", () -> overrideJson);
+            PipesResult pipesResult = pipesClient.process(
+                    new FetchEmitTuple(TEST_DOC, new FetchKey(FETCHER_NAME, TEST_DOC),
+                            new EmitKey(), new Metadata(), parseContext, FetchEmitTuple.ON_PARSE_EXCEPTION.SKIP));
+            assertNotNull(pipesResult.emitData().getMetadataList());
+            assertEquals(1, pipesResult.emitData().getMetadataList().size());
+            metadata = pipesResult.emitData().getMetadataList().get(0);
+        }
 
         // These fields should be present (in the override includeFields or ALWAYS_SET/ADD_FIELDS)
         assertNotNull(metadata.get("Content-Type"), "Content-Type should be present");

tika-pipes/tika-pipes-integration-tests/src/test/java/org/apache/tika/pipes/core/FrictionlessUnpackTest.java

@@ -81,6 +81,7 @@ public void testPassbackFilter(@TempDir Path tmpDir) throws Exception {
                 .emitData()
                 .getMetadataList()
                 .get(0);
+        pipesClient.close();
         assertEquals("TESTOVERLAPPINGTEXT.PDF", metadata.get(TikaCoreProperties.RESOURCE_NAME_KEY));
         assertNull(metadata.get(Metadata.CONTENT_TYPE));
         assertNull(metadata.get(Metadata.CONTENT_LENGTH));