Skip to content

Commit e631e58

Browse files
committed
TIKA-4531: remove leaky / dead / not needed code, fix javadoc
1 parent 05c17f1 commit e631e58

1 file changed

Lines changed: 3 additions & 6 deletions

File tree

  • tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-microsoft-module/src/main/java/org/apache/tika/parser/microsoft/ooxml

tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-microsoft-module/src/main/java/org/apache/tika/parser/microsoft/ooxml/AbstractOOXMLExtractor.java

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@
7272

7373
/**
7474
* Base class for all Tika OOXML extractors.
75-
* <p/>
75+
* <p>
7676
* Tika extractors decorate POI extractors so that the parsed content of
7777
* documents is returned as a sequence of XHTML SAX events. Subclasses must
7878
* implement the buildXHTML method {@link #buildXHTML(XHTMLContentHandler)} that
@@ -332,9 +332,8 @@ private void handleEmbeddedOLE(PackagePart part, XHTMLContentHandler xhtml, Stri
332332
return;
333333
}
334334

335-
InputStream is = part.getInputStream();
336335
// Open the POIFS (OLE2) structure and process
337-
POIFSFileSystem fs = null;
336+
POIFSFileSystem fs;
338337
try {
339338
fs = new POIFSFileSystem(part.getInputStream());
340339
} catch (Exception e) {
@@ -401,9 +400,7 @@ private void handleEmbeddedOLE(PackagePart part, XHTMLContentHandler xhtml, Stri
401400
} catch (IOException e) {
402401
EmbeddedDocumentUtil.recordEmbeddedStreamException(e, parentMetadata);
403402
} finally {
404-
if (fs != null) {
405-
fs.close();
406-
}
403+
fs.close();
407404
if (stream != null) {
408405
stream.close();
409406
}

0 commit comments

Comments
 (0)