TIKA-4813: comment-accuracy follow-ups from the tersification review; (#3017)

Author: tballison

tika-core/src/main/java/org/apache/tika/config/TimeoutLimits.java

@@ -150,7 +150,8 @@ public void setThrowOnDeadline(boolean throwOnDeadline) {
 
     /**
      * Returns this instance if both timeouts are within {@code maxMillis}, otherwise a
-     * copy with each offending timeout reduced to {@code maxMillis}.
+     * copy with each offending timeout reduced to {@code maxMillis}. Used at trust
+     * boundaries to cap request-supplied limits at an operator-set maximum.
      */
     public TimeoutLimits clampedTo(long maxMillis) {
         if (totalTaskTimeoutMillis <= maxMillis && progressTimeoutMillis <= maxMillis) {

tika-parent/pom.xml

@@ -1766,6 +1766,8 @@
         <!-- Skip spotless -->
         <spotless.apply.skip>true</spotless.apply.skip>
         <spotless.check.skip>true</spotless.check.skip>
+        <!-- Skip rat -->
+        <rat.skip>true</rat.skip>
       </properties>
     </profile>
 

tika-parsers/tika-parsers-ml/tika-parser-tess4j-module/src/main/java/org/apache/tika/parser/ocr/tess4j/Tess4JParser.java

@@ -379,8 +379,8 @@ private void returnTesseract(Tesseract tesseract) {
      * {@code tesseract} until doOCR returns on its own. {@code settled} arbitrates the pool
      * return in that case: giver-upper and worker race to CAS it {@code false -> true}, and
      * the loser -- the second to arrive -- returns the instance, so it goes back exactly
-     * once. On a normal return or {@link TesseractException} the worker already finished,
-     * neither side touched {@code settled}, and the caller retains ownership.
+     * once. On a normal return or {@link TesseractException} the waiter never gave up, so
+     * the worker's CAS wins and it skips the pool return -- the caller retains ownership.
      */
     private String doOCRWithTimeout(Tesseract tesseract, BufferedImage image, long requestedMillis,
                                     ParseContext parseContext)

tika-server/tika-server-standard/src/test/java/org/apache/tika/server/standard/MetadataResourceTest.java

@@ -312,8 +312,10 @@ public void testMetaAgreesWithRmeta() throws Exception {
         for (String name : container.names()) {
             // tk:content is absent from both (ignore handler); embedded-only bookkeeping
             // differs because /meta stops at the container; tk:resource-name/tk:source-path
-            // carry the server's per-request spool filename, so they differ by construction.
-            if (name.startsWith("X-TIKA:EXCEPTION") || name.equals("tk:content")
+            // carry the server's per-request spool filename, so they differ by
+            // construction until that is fixed.
+            if (name.startsWith(TikaCoreProperties.TIKA_META_EXCEPTION_PREFIX)
+                    || name.equals("tk:content")
                     || name.startsWith("tk:parsed-by-full-set")
                     || name.equals("tk:resource-name") || name.equals("tk:source-path")
                     || name.equals("tk:parse-time-millis")) {