Skip to content

Commit eb03b30

Browse files
committed
update plugin stages to avoid flaky hudson issues
1 parent 7e81c2d commit eb03b30

17 files changed

Lines changed: 101 additions & 94 deletions

File tree

docs/modules/ROOT/pages/maintainers/release-guides/release-artifacts.adoc

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -146,14 +146,24 @@ API or embedding it programmatically.
146146
Mechanism: `maven-assembly-plugin` with `<attach>false</attach>` in each
147147
plugin pom (TIKA-4723). Because `<attach>false</attach>` also skips the
148148
local-repo install, each plugin pom additionally runs
149-
`maven-install-plugin:install-file` during the `install` phase, writing
149+
`maven-install-plugin:install-file` during the `package` phase, writing
150150
the zip into the local repo at canonical coordinates
151151
(`<groupId>:<artifactId>:zip:<version>`). Sibling modules
152152
(`tika-pipes-fork-parser`, `tika-server-*`, `tika-grpc`, integration
153153
tests) declare the zip as a test-scope Maven dep and rely on this
154154
mechanism to resolve it from the local repo without ever publishing it
155155
to Central.
156156

157+
The `package` binding is deliberate and must not be moved to `install`.
158+
A reactor `mvn package` — what the `tika-main-jdk21` and `tika-main-jdk26`
159+
Jenkins jobs run, and what a contributor building the tree runs — never
160+
reaches the `install` phase, so an `install`-bound `install-file` leaves
161+
the zip unresolvable and every consuming module fails dependency
162+
resolution. It builds only where a previous `mvn install`/`deploy` on the
163+
same machine happened to leave a matching zip in the local repo, which
164+
made the breakage look intermittent until the `4.0.0` → `4.1.0-SNAPSHOT`
165+
bump invalidated every cached copy.
166+
157167
=== tika-grpc
158168

159169
tika-grpc is a standalone gRPC server, parallel to tika-server — not built

tika-parent/pom.xml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1504,9 +1504,6 @@
15041504
<version>3.3.1</version>
15051505
<configuration>
15061506
<autoVersionSubmodules>true</autoVersionSubmodules>
1507-
<!-- 'install' (not the default 'verify') so the install-only pf4j plugin zips
1508-
(attach=false, installed via install:install-file; see tika-pipes plugins)
1509-
are available in the local repo for sibling modules that depend on them. -->
15101507
<preparationGoals>clean install</preparationGoals>
15111508
</configuration>
15121509
<dependencies>

tika-pipes/tika-pipes-plugins/tika-pipes-atlassian-jwt/pom.xml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -131,15 +131,15 @@
131131
<artifactId>maven-install-plugin</artifactId>
132132
<executions>
133133
<!--
134-
The assembly attaches the zip with <attach>false</attach> (TIKA-4723)
135-
so it is not added to the Maven artifact set and therefore is not
136-
deployed to Maven Central. Sibling modules declare this plugin zip
137-
as a test-scope Maven dep, so we install-file it locally to satisfy
138-
reactor resolution without making it part of the project artifacts.
134+
The assembly builds the zip with <attach>false</attach> (TIKA-4723) so it
135+
stays out of the Maven artifact set and off Maven Central. Sibling modules
136+
declare it as a test-scope zip dep, so install-file puts it in the local
137+
repo instead. Bound to package, not install: CI and contributors run
138+
`mvn package`, which has to resolve it too.
139139
-->
140140
<execution>
141141
<id>install-plugin-zip-locally</id>
142-
<phase>install</phase>
142+
<phase>package</phase>
143143
<goals>
144144
<goal>install-file</goal>
145145
</goals>

tika-pipes/tika-pipes-plugins/tika-pipes-az-blob/pom.xml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -117,15 +117,15 @@
117117
<artifactId>maven-install-plugin</artifactId>
118118
<executions>
119119
<!--
120-
The assembly attaches the zip with <attach>false</attach> (TIKA-4723)
121-
so it is not added to the Maven artifact set and therefore is not
122-
deployed to Maven Central. Sibling modules declare this plugin zip
123-
as a test-scope Maven dep, so we install-file it locally to satisfy
124-
reactor resolution without making it part of the project artifacts.
120+
The assembly builds the zip with <attach>false</attach> (TIKA-4723) so it
121+
stays out of the Maven artifact set and off Maven Central. Sibling modules
122+
declare it as a test-scope zip dep, so install-file puts it in the local
123+
repo instead. Bound to package, not install: CI and contributors run
124+
`mvn package`, which has to resolve it too.
125125
-->
126126
<execution>
127127
<id>install-plugin-zip-locally</id>
128-
<phase>install</phase>
128+
<phase>package</phase>
129129
<goals>
130130
<goal>install-file</goal>
131131
</goals>

tika-pipes/tika-pipes-plugins/tika-pipes-csv/pom.xml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -109,15 +109,15 @@
109109
<artifactId>maven-install-plugin</artifactId>
110110
<executions>
111111
<!--
112-
The assembly attaches the zip with <attach>false</attach> (TIKA-4723)
113-
so it is not added to the Maven artifact set and therefore is not
114-
deployed to Maven Central. Sibling modules declare this plugin zip
115-
as a test-scope Maven dep, so we install-file it locally to satisfy
116-
reactor resolution without making it part of the project artifacts.
112+
The assembly builds the zip with <attach>false</attach> (TIKA-4723) so it
113+
stays out of the Maven artifact set and off Maven Central. Sibling modules
114+
declare it as a test-scope zip dep, so install-file puts it in the local
115+
repo instead. Bound to package, not install: CI and contributors run
116+
`mvn package`, which has to resolve it too.
117117
-->
118118
<execution>
119119
<id>install-plugin-zip-locally</id>
120-
<phase>install</phase>
120+
<phase>package</phase>
121121
<goals>
122122
<goal>install-file</goal>
123123
</goals>

tika-pipes/tika-pipes-plugins/tika-pipes-es/pom.xml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -128,15 +128,15 @@
128128
<artifactId>maven-install-plugin</artifactId>
129129
<executions>
130130
<!--
131-
The assembly attaches the zip with <attach>false</attach> (TIKA-4723)
132-
so it is not added to the Maven artifact set and therefore is not
133-
deployed to Maven Central. Sibling modules declare this plugin zip
134-
as a test-scope Maven dep, so we install-file it locally to satisfy
135-
reactor resolution without making it part of the project artifacts.
131+
The assembly builds the zip with <attach>false</attach> (TIKA-4723) so it
132+
stays out of the Maven artifact set and off Maven Central. Sibling modules
133+
declare it as a test-scope zip dep, so install-file puts it in the local
134+
repo instead. Bound to package, not install: CI and contributors run
135+
`mvn package`, which has to resolve it too.
136136
-->
137137
<execution>
138138
<id>install-plugin-zip-locally</id>
139-
<phase>install</phase>
139+
<phase>package</phase>
140140
<goals>
141141
<goal>install-file</goal>
142142
</goals>

tika-pipes/tika-pipes-plugins/tika-pipes-file-system/pom.xml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -121,15 +121,15 @@
121121
<artifactId>maven-install-plugin</artifactId>
122122
<executions>
123123
<!--
124-
The assembly attaches the zip with <attach>false</attach> (TIKA-4723)
125-
so it is not added to the Maven artifact set and therefore is not
126-
deployed to Maven Central. Sibling modules declare this plugin zip
127-
as a test-scope Maven dep, so we install-file it locally to satisfy
128-
reactor resolution without making it part of the project artifacts.
124+
The assembly builds the zip with <attach>false</attach> (TIKA-4723) so it
125+
stays out of the Maven artifact set and off Maven Central. Sibling modules
126+
declare it as a test-scope zip dep, so install-file puts it in the local
127+
repo instead. Bound to package, not install: CI and contributors run
128+
`mvn package`, which has to resolve it too.
129129
-->
130130
<execution>
131131
<id>install-plugin-zip-locally</id>
132-
<phase>install</phase>
132+
<phase>package</phase>
133133
<goals>
134134
<goal>install-file</goal>
135135
</goals>

tika-pipes/tika-pipes-plugins/tika-pipes-gcs/pom.xml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -113,15 +113,15 @@
113113
<artifactId>maven-install-plugin</artifactId>
114114
<executions>
115115
<!--
116-
The assembly attaches the zip with <attach>false</attach> (TIKA-4723)
117-
so it is not added to the Maven artifact set and therefore is not
118-
deployed to Maven Central. Sibling modules declare this plugin zip
119-
as a test-scope Maven dep, so we install-file it locally to satisfy
120-
reactor resolution without making it part of the project artifacts.
116+
The assembly builds the zip with <attach>false</attach> (TIKA-4723) so it
117+
stays out of the Maven artifact set and off Maven Central. Sibling modules
118+
declare it as a test-scope zip dep, so install-file puts it in the local
119+
repo instead. Bound to package, not install: CI and contributors run
120+
`mvn package`, which has to resolve it too.
121121
-->
122122
<execution>
123123
<id>install-plugin-zip-locally</id>
124-
<phase>install</phase>
124+
<phase>package</phase>
125125
<goals>
126126
<goal>install-file</goal>
127127
</goals>

tika-pipes/tika-pipes-plugins/tika-pipes-google-drive/pom.xml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -181,15 +181,15 @@
181181
<artifactId>maven-install-plugin</artifactId>
182182
<executions>
183183
<!--
184-
The assembly attaches the zip with <attach>false</attach> (TIKA-4723)
185-
so it is not added to the Maven artifact set and therefore is not
186-
deployed to Maven Central. Sibling modules declare this plugin zip
187-
as a test-scope Maven dep, so we install-file it locally to satisfy
188-
reactor resolution without making it part of the project artifacts.
184+
The assembly builds the zip with <attach>false</attach> (TIKA-4723) so it
185+
stays out of the Maven artifact set and off Maven Central. Sibling modules
186+
declare it as a test-scope zip dep, so install-file puts it in the local
187+
repo instead. Bound to package, not install: CI and contributors run
188+
`mvn package`, which has to resolve it too.
189189
-->
190190
<execution>
191191
<id>install-plugin-zip-locally</id>
192-
<phase>install</phase>
192+
<phase>package</phase>
193193
<goals>
194194
<goal>install-file</goal>
195195
</goals>

tika-pipes/tika-pipes-plugins/tika-pipes-http/pom.xml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -197,15 +197,15 @@
197197
<artifactId>maven-install-plugin</artifactId>
198198
<executions>
199199
<!--
200-
The assembly attaches the zip with <attach>false</attach> (TIKA-4723)
201-
so it is not added to the Maven artifact set and therefore is not
202-
deployed to Maven Central. Sibling modules declare this plugin zip
203-
as a test-scope Maven dep, so we install-file it locally to satisfy
204-
reactor resolution without making it part of the project artifacts.
200+
The assembly builds the zip with <attach>false</attach> (TIKA-4723) so it
201+
stays out of the Maven artifact set and off Maven Central. Sibling modules
202+
declare it as a test-scope zip dep, so install-file puts it in the local
203+
repo instead. Bound to package, not install: CI and contributors run
204+
`mvn package`, which has to resolve it too.
205205
-->
206206
<execution>
207207
<id>install-plugin-zip-locally</id>
208-
<phase>install</phase>
208+
<phase>package</phase>
209209
<goals>
210210
<goal>install-file</goal>
211211
</goals>

0 commit comments

Comments
 (0)