From 35824cca004ea2805cc3386de32b7ad0bc5dfdf1 Mon Sep 17 00:00:00 2001 From: Tilman Hausherr Date: Sun, 29 Mar 2026 15:01:37 +0200 Subject: [PATCH 1/2] TIKA-4704: delete on exit in case delete fails --- tika-core/src/main/java/org/apache/tika/fork/ForkClient.java | 1 + 1 file changed, 1 insertion(+) diff --git a/tika-core/src/main/java/org/apache/tika/fork/ForkClient.java b/tika-core/src/main/java/org/apache/tika/fork/ForkClient.java index f1a47206d9b..1500e255f4e 100644 --- a/tika-core/src/main/java/org/apache/tika/fork/ForkClient.java +++ b/tika-core/src/main/java/org/apache/tika/fork/ForkClient.java @@ -324,6 +324,7 @@ public synchronized void close() { } if (jar != null) { jar.delete(); + jar.deleteOnExit(); } } From 9d994dc3a6f145221f75ec7d0008d4b104aaab3e Mon Sep 17 00:00:00 2001 From: Tilman Hausherr Date: Sun, 29 Mar 2026 15:08:48 +0200 Subject: [PATCH 2/2] delete on exit only if really needed Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --- tika-core/src/main/java/org/apache/tika/fork/ForkClient.java | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tika-core/src/main/java/org/apache/tika/fork/ForkClient.java b/tika-core/src/main/java/org/apache/tika/fork/ForkClient.java index 1500e255f4e..8bacaf83f05 100644 --- a/tika-core/src/main/java/org/apache/tika/fork/ForkClient.java +++ b/tika-core/src/main/java/org/apache/tika/fork/ForkClient.java @@ -323,8 +323,9 @@ public synchronized void close() { } } if (jar != null) { - jar.delete(); - jar.deleteOnExit(); + if (!jar.delete()) { + jar.deleteOnExit(); + } } }