Fixing PMD

Author: coheigea

src/main/resources/xmlschema-pmd-ruleset.xml

@@ -37,6 +37,7 @@
      <exclude name="ForLoopCanBeForeach" />
      <exclude name="ForLoopVariableCount" />
      <exclude name="GuardLogStatement" />
+     <exclude name="ImplicitFunctionalInterface" />
      <exclude name="LooseCoupling" />
      <exclude name="JUnitAssertionsShouldIncludeMessage"/>
      <exclude name="JUnitTestContainsTooManyAsserts" />

xmlschema-walker/src/main/java/org/apache/ws/commons/schema/docpath/SaxWalkerOverDom.java

@@ -286,10 +286,7 @@ public void addContentHandler(ContentHandler contentHandler) {
      * @return <code>true</code> if it was found, <code>false</code> if not.
      */
     public boolean removeContentHandler(ContentHandler contentHandler) {
-        if (listeners != null) {
-            return listeners.remove(contentHandler);
-        }
-        return false;
+        return listeners != null && listeners.remove(contentHandler);
     }
 
     /**

xmlschema-walker/src/main/java/org/apache/ws/commons/schema/docpath/XmlSchemaElementValidator.java

@@ -111,7 +111,7 @@ static void validateAttributes(XmlSchemaStateMachineNode state, Attributes attrs
             }
 
             // Confirm the attribute is used correctly.
-            switch (use) {
+            switch (use) { //NOPMD
             case OPTIONAL:
                 break;
             case PROHIBITED:

xmlschema-walker/src/main/java/org/apache/ws/commons/schema/docpath/XmlSchemaPathFinder.java

@@ -98,7 +98,7 @@ private static final class PathSegment<U, V> implements Comparable<PathSegment<U
         }
 
         @Override
-        public int compareTo(PathSegment<U, V> o) {
+        public int compareTo(PathSegment<U, V> o) { //NOPMD
             if (this == o) {
                 return 0;
             }

xmlschema-walker/src/main/java/org/apache/ws/commons/schema/docpath/XmlSchemaPathManager.java

@@ -55,7 +55,7 @@ XmlSchemaPathNode<U, V> addParentSiblingOrContentNodeToPath(XmlSchemaPathNode<U,
             if (position != null) {
                 position = position.getParent();
             }
-        case SIBLING:
+        case SIBLING: //NOPMD
         case CONTENT:
             if (position == null) {
                 throw new IllegalStateException(