[YUNIKORN-974] Fix deadlock in Application.IsAllocationAssignedToApp() (#347)

craigcondit · craigcondit · commit b869c87702ec · 2021-12-13T12:49:07.000-06:00
Closes: #347
diff --git a/pkg/scheduler/objects/application.go b/pkg/scheduler/objects/application.go
@@ -1451,7 +1451,7 @@ func (sa *Application) notifyRMAllocationAskReleased(rmID string, released []*Al
 
 func (sa *Application) IsAllocationAssignedToApp(alloc *Allocation) bool {
 	sa.RLock()
-	defer sa.RLock()
+	defer sa.RUnlock()
 	_, ok := sa.allocations[alloc.UUID]
 	return ok
 }

Original file line number	Diff line number	Diff line change
`@@ -1451,7 +1451,7 @@ func (sa Application) notifyRMAllocationAskReleased(rmID string, released []Al`
`1451`	`1451`
`1452`	`1452`	`func (sa Application) IsAllocationAssignedToApp(alloc Allocation) bool {`
`1453`	`1453`	`sa.RLock()`
`1454`		`- defer sa.RLock()`
	`1454`	`+ defer sa.RUnlock()`
`1455`	`1455`	`_, ok := sa.allocations[alloc.UUID]`
`1456`	`1456`	`return ok`
`1457`	`1457`	`}`