Skip to content

Commit 09a08e9

Browse files
committed
fix broken tests
1 parent cbe785e commit 09a08e9

3 files changed

Lines changed: 7 additions & 5 deletions

File tree

zeppelin-web-angular/e2e/models/header-page.util.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -51,9 +51,10 @@ export class HeaderPageUtil {
5151

5252
async verifyNotebookDropdownOpens(): Promise<void> {
5353
await this.headerPage.clickNotebookMenu();
54-
// Target the header dropdown version specifically using ng-reflect-header-mode attribute
55-
const dropdownNodeList = this.page.locator('zeppelin-node-list[ng-reflect-header-mode="true"]');
56-
await expect(dropdownNodeList).toBeVisible();
54+
await expect(this.headerPage.notebookDropdown).toBeVisible();
55+
56+
const nodeList = new NodeListPage(this.page);
57+
await expect(nodeList.createNewNoteButton).toBeVisible();
5758
}
5859

5960
async verifyAboutZeppelinModalOpens(): Promise<void> {

zeppelin-web-angular/e2e/models/note-create-modal.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -82,6 +82,7 @@ export class NoteCreateModal extends BasePage {
8282

8383
async getAvailableInterpreters(): Promise<string[]> {
8484
await this.openInterpreterDropdown();
85+
await this.interpreterOptions.first().waitFor({ state: 'visible', timeout: 5000 });
8586
const options = await this.interpreterOptions.allTextContents();
8687
await this.page.keyboard.press('Escape');
8788
return options;

zeppelin-web-angular/e2e/models/note-create-modal.util.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,8 @@ export class NoteCreateModalUtil {
3939

4040
async verifyInterpreterSelectionWorks(): Promise<void> {
4141
await this.modal.openInterpreterDropdown();
42-
await expect(this.modal.interpreterOptions.first()).toBeVisible();
43-
42+
await this.modal.interpreterOptions.first().waitFor({ state: 'attached', timeout: 30000 });
43+
await expect(this.modal.interpreterOptions.first()).toBeVisible({ timeout: 30000 });
4444
const interpreters = await this.modal.getAvailableInterpreters();
4545
expect(interpreters.length).toBeGreaterThan(0);
4646
}

0 commit comments

Comments
 (0)