fix broken tests

Author: voidmatcha

zeppelin-web-angular/e2e/models/home-page.ts

@@ -117,12 +117,12 @@ export class HomePage extends BasePage {
   }
 
   async navigateToHome(): Promise<void> {
-    await this.page.goto('/', { waitUntil: 'load' });
+    await this.page.goto('/');
     await this.waitForPageLoad();
   }
 
   async navigateToLogin(): Promise<void> {
-    await this.page.goto('/#/login', { waitUntil: 'load' });
+    await this.page.goto('/#/login');
     await this.waitForPageLoad();
     // Wait for potential redirect to complete by checking URL change
     await waitForUrlNotContaining(this.page, '#/login');
@@ -189,6 +189,7 @@ export class HomePage extends BasePage {
   }
 
   async filterNotes(searchTerm: string): Promise<void> {
+    await this.nodeList.filterInput.waitFor({ state: 'visible', timeout: 5000 });
     await this.nodeList.filterInput.fill(searchTerm);
   }
 

zeppelin-web-angular/e2e/models/home-page.util.ts

@@ -183,31 +183,23 @@ export class HomePageUtil {
   async verifyCreateNewNoteWorkflow(): Promise<void> {
     await this.homePage.clickCreateNewNote();
 
-    await this.page.waitForFunction(
-      () => {
-        return document.querySelector('zeppelin-note-create') !== null;
-      },
-      { timeout: 10000 }
-    );
+    await this.page.waitForFunction(() => document.querySelector('zeppelin-note-create') !== null, { timeout: 10000 });
   }
 
   async verifyImportNoteWorkflow(): Promise<void> {
     await this.homePage.clickImportNote();
 
-    await this.page.waitForFunction(
-      () => {
-        return document.querySelector('zeppelin-note-import') !== null;
-      },
-      { timeout: 10000 }
-    );
+    await this.page.waitForFunction(() => document.querySelector('zeppelin-note-import') !== null, { timeout: 10000 });
   }
 
   async testFilterFunctionality(filterTerm: string): Promise<void> {
     await this.homePage.filterNotes(filterTerm);
 
-    await this.page.waitForTimeout(1000);
+    const notebookTreeLocator = this.page.locator('nz-tree .node');
+    await notebookTreeLocator.first().waitFor({ state: 'attached', timeout: 5000 });
+    await this.page.waitForLoadState('domcontentloaded');
 
-    const filteredResults = await this.page.locator('nz-tree .node').count();
+    const filteredResults = await notebookTreeLocator.count();
     expect(filteredResults).toBeGreaterThanOrEqual(0);
   }
 

zeppelin-web-angular/e2e/tests/home/home-page-note-operations.spec.ts

@@ -24,7 +24,8 @@ test.describe('Home Page Note Operations', () => {
     await page.goto('/');
     await waitForZeppelinReady(page);
     await performLoginIfRequired(page);
-    await page.waitForSelector('zeppelin-node-list', { timeout: 15000 });
+    const noteListLocator = page.locator('zeppelin-node-list');
+    await expect(noteListLocator).toBeVisible({ timeout: 15000 });
   });
 
   test.describe('Given note operations are available', () => {
@@ -93,13 +94,10 @@ test.describe('Home Page Note Operations', () => {
 
         await page
           .waitForFunction(
-            () => {
-              return (
-                document.querySelector('zeppelin-note-rename') !== null ||
-                document.querySelector('[role="dialog"]') !== null ||
-                document.querySelector('.ant-modal') !== null
-              );
-            },
+            () =>
+              document.querySelector('zeppelin-note-rename') !== null ||
+              document.querySelector('[role="dialog"]') !== null ||
+              document.querySelector('.ant-modal') !== null,
             { timeout: 5000 }
           )
           .catch(() => {