Skip to content

Commit 9118d9f

Browse files
authored
[receiver/expvar] Enable re-aggregation feature (open-telemetry#46979)
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Enabling re-aggregation for the expvar receiver. PR solves: open-telemetry#46354 Part of: open-telemetry#45396. <!--Describe what testing was performed and which tests were added.--> #### Testing - Ran `make mdatagen` to regenerate the internal metadata code. - Updated `config_test.go` & `scraper_test.go` - Validated `make test` and `make lint`
1 parent 621cd77 commit 9118d9f

File tree

9 files changed

+877
-268
lines changed

9 files changed

+877
-268
lines changed
Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
change_type: enhancement
2+
3+
component: receiver/expvar
4+
5+
note: Enable the re-aggregation feature for the expvar receiver
6+
7+
issues: [45396]
8+
9+
subtext:
10+
11+
change_logs: [user]

receiver/expvarreceiver/config_test.go

Lines changed: 28 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,34 @@ func TestLoadConfig(t *testing.T) {
8686
}
8787
assert.NoError(t, xconfmap.Validate(cfg))
8888
if diff := cmp.Diff(tt.expected, cfg,
89-
cmpopts.IgnoreUnexported(metadata.MetricConfig{}),
89+
cmpopts.IgnoreUnexported(
90+
metadata.ProcessRuntimeMemstatsBuckHashSysMetricConfig{},
91+
metadata.ProcessRuntimeMemstatsFreesMetricConfig{},
92+
metadata.ProcessRuntimeMemstatsGcCPUFractionMetricConfig{},
93+
metadata.ProcessRuntimeMemstatsGcSysMetricConfig{},
94+
metadata.ProcessRuntimeMemstatsHeapAllocMetricConfig{},
95+
metadata.ProcessRuntimeMemstatsHeapIdleMetricConfig{},
96+
metadata.ProcessRuntimeMemstatsHeapInuseMetricConfig{},
97+
metadata.ProcessRuntimeMemstatsHeapObjectsMetricConfig{},
98+
metadata.ProcessRuntimeMemstatsHeapReleasedMetricConfig{},
99+
metadata.ProcessRuntimeMemstatsHeapSysMetricConfig{},
100+
metadata.ProcessRuntimeMemstatsLastPauseMetricConfig{},
101+
metadata.ProcessRuntimeMemstatsLookupsMetricConfig{},
102+
metadata.ProcessRuntimeMemstatsMallocsMetricConfig{},
103+
metadata.ProcessRuntimeMemstatsMcacheInuseMetricConfig{},
104+
metadata.ProcessRuntimeMemstatsMcacheSysMetricConfig{},
105+
metadata.ProcessRuntimeMemstatsMspanInuseMetricConfig{},
106+
metadata.ProcessRuntimeMemstatsMspanSysMetricConfig{},
107+
metadata.ProcessRuntimeMemstatsNextGcMetricConfig{},
108+
metadata.ProcessRuntimeMemstatsNumForcedGcMetricConfig{},
109+
metadata.ProcessRuntimeMemstatsNumGcMetricConfig{},
110+
metadata.ProcessRuntimeMemstatsOtherSysMetricConfig{},
111+
metadata.ProcessRuntimeMemstatsPauseTotalMetricConfig{},
112+
metadata.ProcessRuntimeMemstatsStackInuseMetricConfig{},
113+
metadata.ProcessRuntimeMemstatsStackSysMetricConfig{},
114+
metadata.ProcessRuntimeMemstatsSysMetricConfig{},
115+
metadata.ProcessRuntimeMemstatsTotalAllocMetricConfig{},
116+
),
90117
cmpopts.IgnoreUnexported(configoptional.Optional[configauth.Config]{}),
91118
cmpopts.IgnoreUnexported(configoptional.Optional[confighttp.CookiesConfig]{}),
92119
); diff != "" {

0 commit comments

Comments
 (0)