EagerLoadingExtension does not check for existing joins

[tezvi]

EagerLoadingExtension does not check whether the query builder already defines exact join clause.
If another extension adds join before the EagerLoadingExtension it will result with duplicate join clauses.

core/src/Bridge/Doctrine/Orm/Extension/EagerLoadingExtension.php

Lines 200 to 201 in ee7ef88

	$associationAlias = $queryNameGenerator->generateJoinAlias($association);
	$queryBuilder->{$method}(sprintf('%s.%s', $parentAlias, $association), $associationAlias);

[viconnex]

Hi ! I would love to help you on this issue/
I could get all previously used aliases with $queryBuilder->getAllAliases() and check if the current $association matches one part of existing aliases.
What do you think @soyuka @dunglas ?

[soyuka]

Hi @victorbrun we have methods like this one:

core/src/Bridge/Doctrine/Orm/Util/QueryChecker.php

Line 168 in 5f7eaf3

public static function hasLeftJoin(QueryBuilder $queryBuilder): bool

They should be used there, what I'd do first is to try to reproduce a failing test case, then I'd try to fix it using these checks.

[tezvi]

Not sure if this is obvious but we should check for any join type, not just a lefty.
Cheers